Skip to content

GH-46593: [CI][Integration] Disable nested log grouping #46594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

kou
Copy link
Member

@kou kou commented May 27, 2025

Rationale for this change

GitHub Actions support log grouping:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines

But it doesn't support nested grouping.

If we nest grouping, some logs may not be grouped. See #46593 for example.

What changes are included in this PR?

Stop GitHub Actions workflow commands including grouping while grouping.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #46593 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label May 27, 2025
@kou
Copy link
Member Author

kou commented May 27, 2025

Worked. (No details log for "Integration: Build: Java".)

https://github.com/apache/arrow/actions/runs/15264629388/job/42928067316?pr=46594#step:12:253

Integration: Build: Rust
Integration: Build: nanoarrow
Integration: Build: Go
Integration: Build: C++
Integration: Build: C#
Integration: Build: Java
+ '[' 1 -gt 0 ']'
+ /arrow/js/ci/scripts/build.sh /arrow/js
Integration: Build: JavaScript
+ pip install -e '/arrow/dev/archery[integration]'
Integration: Prepare: Archery

@kou
Copy link
Member Author

kou commented May 30, 2025

+1

@kou kou merged commit 15ccd6d into apache:main May 30, 2025
25 of 26 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label May 30, 2025
@kou kou deleted the ci-integration-log branch May 30, 2025 02:41
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 15ccd6d.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant