-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip #46591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…through a potentially hard to understand pitfall related to tzdata apache#46080
@github-actions crossbow submit preview-docs |
|
|
@github-actions crossbow submit preview-docs |
Revision: 6bf917a Submitted crossbow builds: ursacomputing/crossbow @ actions-6606098298
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR — much appreciated!
I've added a few comments. Also, I think this content would fit better under the Dependencies/tzdata on Windows
section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should clearly specify that this is for Windows and ORC. Otherwise seems to broad and people with other setups that are having other unrelated issues might get confused by this.
Can you put it after the section:
https://github.com/apache/arrow/blob/19439118ce25620b9773fe3616aa1e4dab4fd098/docs/source/python/install.rst#tzdata-on-windows
Co-authored-by: Sutou Kouhei <[email protected]>
…able Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
@github-actions crossbow submit preview-docs |
Revision: 6a48384 Submitted crossbow builds: ursacomputing/crossbow @ actions-b62a238c01
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Adding just 3 more nits then it is good to go.
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
Co-authored-by: Alenka Frim <[email protected]>
@AlenkaF I appreciate all the nits. Writing documentation has never been my strong suit. Really appreciate everything you all do for this open source package. It makes my life so much easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the updates! I will merge this once I get back behind the computer.
@github-actions crossbow submit preview-docs |
Revision: 4ac6fc3 Submitted crossbow builds: ursacomputing/crossbow @ actions-07de9c2772
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 707fa6b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Thanks for opening a pull request!
Rationale for this change
When installing pyarrow with pip, it is possible to experience a confusing time zone related error when writing files with datetime data. #46080 discusses the problem and a solution was eventually found. This change provides helpful information to other users who may experience the problem.
What changes are included in this PR?
Update to python installation instructions that offers guidance on how to handle tzdata related errors
Are these changes tested?
I was unable to build the documentation locally. I will use the github action to preview the documentation
Are there any user-facing changes?
No