Skip to content

GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip #46591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 30, 2025

Conversation

kahemker
Copy link
Contributor

@kahemker kahemker commented May 26, 2025

Thanks for opening a pull request!

Rationale for this change

When installing pyarrow with pip, it is possible to experience a confusing time zone related error when writing files with datetime data. #46080 discusses the problem and a solution was eventually found. This change provides helpful information to other users who may experience the problem.

What changes are included in this PR?

Update to python installation instructions that offers guidance on how to handle tzdata related errors

Are these changes tested?

I was unable to build the documentation locally. I will use the github action to preview the documentation

Are there any user-facing changes?

No

kahemker and others added 2 commits May 26, 2025 16:48
@kahemker
Copy link
Contributor Author

@github-actions crossbow submit preview-docs

Copy link

⚠️ GitHub issue #46080 has been automatically assigned in GitHub to PR creator.

Copy link

Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/15261860672

@kou
Copy link
Member

kou commented May 27, 2025

@github-actions crossbow submit preview-docs

@kou kou requested review from raulcd and AlenkaF May 27, 2025 00:51
@kou kou changed the title GH-46080 [Docs] Provide guidance for tzdata related issues if installing with pip GH-46080 [Python][Docs] Provide guidance for tzdata related issues if installing with pip May 27, 2025
@kou kou requested a review from wgtmac May 27, 2025 00:52
Copy link

Revision: 6bf917a

Submitted crossbow builds: ursacomputing/crossbow @ actions-6606098298

Task Status
preview-docs GitHub Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels May 27, 2025
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR — much appreciated!
I've added a few comments. Also, I think this content would fit better under the Dependencies/tzdata on Windows section.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should clearly specify that this is for Windows and ORC. Otherwise seems to broad and people with other setups that are having other unrelated issues might get confused by this.
Can you put it after the section:
https://github.com/apache/arrow/blob/19439118ce25620b9773fe3616aa1e4dab4fd098/docs/source/python/install.rst#tzdata-on-windows

@github-actions github-actions bot removed the awaiting changes Awaiting changes label May 27, 2025
@github-actions github-actions bot added the awaiting change review Awaiting change review label May 27, 2025
@kahemker
Copy link
Contributor Author

@kou @raulcd @AlenkaF , I think I took all your feedback and updated this branch. Anything else?

@kou
Copy link
Member

kou commented May 27, 2025

@github-actions crossbow submit preview-docs

Copy link

Revision: 6a48384

Submitted crossbow builds: ursacomputing/crossbow @ actions-b62a238c01

Task Status
preview-docs GitHub Actions

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Adding just 3 more nits then it is good to go.

kahemker and others added 3 commits May 28, 2025 18:26
@kahemker
Copy link
Contributor Author

@AlenkaF I appreciate all the nits. Writing documentation has never been my strong suit. Really appreciate everything you all do for this open source package. It makes my life so much easier.

Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the updates! I will merge this once I get back behind the computer.

@AlenkaF
Copy link
Member

AlenkaF commented May 30, 2025

@github-actions crossbow submit preview-docs

Copy link

Revision: 4ac6fc3

Submitted crossbow builds: ursacomputing/crossbow @ actions-07de9c2772

Task Status
preview-docs GitHub Actions

@AlenkaF AlenkaF merged commit 707fa6b into apache:main May 30, 2025
4 of 6 checks passed
@AlenkaF AlenkaF removed the awaiting change review Awaiting change review label May 30, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 707fa6b.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants