Remove allow unused from arrow-avro lib.rs file #8493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nctions within `arrow-avro`; bug fixes; centralize nullability handling; enforce spec-compliant alias and default value behavior; and improve tests with canonical form validation.
github-actions
bot
added
arrow
jecsand838
force-pushed
the
remove-allow-unused
branch
4 times, most recently
from
08c66ac to
1c1ce2a
Compare
jecsand838
force-pushed
the
remove-allow-unused
branch
from
1c1ce2a to
0b46244
Compare
jecsand838
force-pushed
the
remove-allow-unused
branch
from
58cfe47 to
c295fab
Compare
|
Thanks @jecsand838 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NOTE: This PR is stacked on #8492
Rationale for this change
arrow-avrohas seen significant development since#![allow(unused)]was temporarily added tolib.rs. Due to fast iteration on the code, this has led to unused methods and imports throughout the crate, which need to be cleaned up prior toarrow-avrobecoming public.This PR simply removes
#![allow(unused)]and cleans up thearrow-avrocrate's code to comply.What changes are included in this PR?
Deleted the
#![allow(unused)]inlib.rsand updated the crate's code as needed. This impacted almost every files of the crate, however the changes in this PR are 100% focused and isolated around only the work related to removing#![allow(unused)].Are these changes tested?
The changes in this PR are covered by existing tests. No new functionality or behavior has been changed/added. This PR is simply clean up around removing
#![allow(unused)]fromlib.rs.Are there any user-facing changes?
N/A