-
Notifications
You must be signed in to change notification settings - Fork 919
[Variant] Add (empty) parquet-variant
crate, update parquet-testing
pin
#7485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
parquet-variant
crate
0681190
to
cdab392
Compare
parquet-variant
crateparquet-variant
crate, update parquet-testing
pin
@crepererum or @wjones127 or @mbrobbel I wonder if you have a few minutes to review this PR. I hope it is non controversial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though I think the readme description could be confusing to some as is.
Cargo.toml
Outdated
strip = false No newline at end of file | ||
strip = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an unnecessary change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is something my editor does by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wjones127, @mbrobbel and @adriangb for the reviews
I just found that the parquet-java implementation also has something called https://github.com/apache/parquet-java/tree/master/parquet-variant/src Which was added a few days ago with @gene-db: |
Ok, let's merge this to keep the code flowing. I tried to address @wjones127 's comment, but if it is still confusing I would be more than happy to make a follow on PR to further clarify |
Which issue does this PR close?
Rationale for this change
We are adding support for Variant and thus we should add a new crate where the new code will live and that clearly explains the current status.
What changes are included in this PR?
parquet-variant
crateparquet-testing
submodule to include variant test data added in Add example binary variant data and regeneration scripts parquet-testing#76Are there any user-facing changes?
Not yet