Skip to content

Upgrade to object_store to 0.12.0 #7328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parquet/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ arrow-data = { workspace = true, optional = true }
arrow-schema = { workspace = true, optional = true }
arrow-select = { workspace = true, optional = true }
arrow-ipc = { workspace = true, optional = true }
object_store = { version = "0.11.0", default-features = false, optional = true }
object_store = { version = "0.12.0", default-features = false, optional = true }

bytes = { version = "1.1", default-features = false, features = ["std"] }
thrift = { version = "0.17", default-features = false }
Expand Down Expand Up @@ -85,7 +85,7 @@ serde_json = { version = "1.0", features = ["std"], default-features = false }
arrow = { workspace = true, features = ["ipc", "test_utils", "prettyprint", "json"] }
tokio = { version = "1.0", default-features = false, features = ["macros", "rt-multi-thread", "io-util", "fs"] }
rand = { version = "0.9", default-features = false, features = ["std", "std_rng", "thread_rng"] }
object_store = { version = "0.11.0", default-features = false, features = ["azure"] }
object_store = { version = "0.12.0", default-features = false, features = ["azure", "fs"] }
sysinfo = { version = "0.34.0", default-features = false, features = ["system"] }

[package.metadata.docs.rs]
Expand Down
23 changes: 14 additions & 9 deletions parquet/src/arrow/async_reader/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ use tokio::runtime::Handle;
/// println!("Found Blob with {}B at {}", meta.size, meta.location);
///
/// // Show Parquet metadata
/// let reader = ParquetObjectReader::new(storage_container, meta.location).with_file_size(meta.size);
/// let reader = ParquetObjectReader::new(storage_container, meta.location).with_file_size(meta.size.try_into().unwrap());
/// let builder = ParquetRecordBatchStreamBuilder::new(reader).await.unwrap();
/// print_parquet_metadata(&mut stdout(), builder.metadata());
/// # }
Expand Down Expand Up @@ -163,7 +163,7 @@ impl ParquetObjectReader {
impl MetadataSuffixFetch for &mut ParquetObjectReader {
fn fetch_suffix(&mut self, suffix: usize) -> BoxFuture<'_, Result<Bytes>> {
let options = GetOptions {
range: Some(GetRange::Suffix(suffix)),
range: Some(GetRange::Suffix(suffix as u64)),
..Default::default()
};
self.spawn(|store, path| {
Expand All @@ -178,13 +178,18 @@ impl MetadataSuffixFetch for &mut ParquetObjectReader {

impl AsyncFileReader for ParquetObjectReader {
fn get_bytes(&mut self, range: Range<usize>) -> BoxFuture<'_, Result<Bytes>> {
let range = range.start as u64..range.end as u64;
self.spawn(|store, path| store.get_range(path, range))
}

fn get_byte_ranges(&mut self, ranges: Vec<Range<usize>>) -> BoxFuture<'_, Result<Vec<Bytes>>>
where
Self: Send,
{
let ranges = ranges
.into_iter()
.map(|range| range.start as u64..range.end as u64)
.collect::<Vec<_>>();
self.spawn(|store, path| async move { store.get_ranges(path, &ranges).await }.boxed())
}

Expand Down Expand Up @@ -254,8 +259,8 @@ mod tests {
#[tokio::test]
async fn test_simple() {
let (meta, store) = get_meta_store().await;
let object_reader =
ParquetObjectReader::new(store, meta.location).with_file_size(meta.size);
let object_reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size.try_into().unwrap());

let builder = ParquetRecordBatchStreamBuilder::new(object_reader)
.await
Expand Down Expand Up @@ -285,8 +290,8 @@ mod tests {
let (mut meta, store) = get_meta_store().await;
meta.location = Path::from("I don't exist.parquet");

let object_reader =
ParquetObjectReader::new(store, meta.location).with_file_size(meta.size);
let object_reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size.try_into().unwrap());
// Cannot use unwrap_err as ParquetRecordBatchStreamBuilder: !Debug
match ParquetRecordBatchStreamBuilder::new(object_reader).await {
Ok(_) => panic!("expected failure"),
Expand Down Expand Up @@ -320,7 +325,7 @@ mod tests {
let initial_actions = num_actions.load(Ordering::Relaxed);

let reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size)
.with_file_size(meta.size.try_into().unwrap())
.with_runtime(rt.handle().clone());

let builder = ParquetRecordBatchStreamBuilder::new(reader).await.unwrap();
Expand Down Expand Up @@ -348,7 +353,7 @@ mod tests {
let (meta, store) = get_meta_store().await;

let reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size)
.with_file_size(meta.size.try_into().unwrap())
.with_runtime(rt.handle().clone());

let current_id = std::thread::current().id();
Expand All @@ -373,7 +378,7 @@ mod tests {
let (meta, store) = get_meta_store().await;

let mut reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size)
.with_file_size(meta.size.try_into().unwrap())
.with_runtime(rt.handle().clone());

rt.shutdown_background();
Expand Down
3 changes: 2 additions & 1 deletion parquet/tests/encryption/encryption_async.rs
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ async fn test_read_encrypted_file_from_object_store() {
.unwrap();
let options = ArrowReaderOptions::new().with_file_decryption_properties(decryption_properties);

let mut reader = ParquetObjectReader::new(store, meta.location).with_file_size(meta.size);
let mut reader = ParquetObjectReader::new(store, meta.location)
.with_file_size(meta.size.try_into().unwrap());
let metadata = reader.get_metadata(Some(&options)).await.unwrap();
let builder = ParquetRecordBatchStreamBuilder::new_with_options(reader, options)
.await
Expand Down
Loading