Minor: rename ParquetRecordBatchStream::reader to ParquetRecordBatchStream::reader_factory
#7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chStream::factory`
alamb
commented
Mar 21, 2025
| @@ -557,7 +557,7 @@ impl<T: AsyncFileReader + Send + 'static> ParquetRecordBatchStreamBuilder<T> { | |||
| let batch_size = self | |||
| .batch_size | |||
| .min(self.metadata.file_metadata().num_rows() as usize); | |||
| let reader = ReaderFactory { | |||
| let reader_factory = ReaderFactory { | |||
There was a problem hiding this comment.
reader_factory I think better expresses that this is not a Reader but something that makes Readers
alamb
changed the title
ParquetRecordBatchStream::reader to ParquetRecordBatchStream::factoryParquetRecordBatchStream::reader to ParquetRecordBatchStream::reader_factory
|
FYI @XiangpengHao |
etseidl
approved these changes
Mar 25, 2025
|
Thanks for the review @etseidl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ParquetRecordBatchStream is complicated (not unecessairly so), and it is hard for me to keep track of all the various readers, which gets all the more complicated with #6921 from @XiangpengHao
It turns out the field named
readeronParquetRecordBatchStreamis actually aReaderFactory.What changes are included in this PR?
Change the name of the field to reflect that it is a factory that makes readers, not a reader itself
Are there any user-facing changes?
No, this is an internal code change