Skip to content

MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0 #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbonofre merged 6 commits into from
May 10, 2026
Merged

MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0 #1140

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33cdae4
MINOR: Fix Gandiva JNI build against Arrow C++ 24.0.0
jbonofre May 7, 2026
18b8d46
MINOR: Install xsimd via vcpkg before building Arrow C++ 24.0.0
jbonofre May 7, 2026
156fe70
MINOR: Pass vcpkg toolchain to Arrow C++ CMake configure step
jbonofre May 7, 2026
c9bbc79
MINOR: Use Arrow bundled xsimd 14.0.0 instead of stale vcpkg registry
jbonofre May 7, 2026
6ef0593
Update vcpkg
jbonofre May 8, 2026
2961cc7
MINOR: Fix vcpkg-jni Docker command to use explicit bash invocation
jbonofre May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ci/scripts/jni_manylinux_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ cmake \
-S "${arrow_dir}/cpp" \
-B "${build_dir}/cpp" \
--preset=ninja-release-jni-linux \
-DCMAKE_INSTALL_PREFIX="${install_dir}"
-DCMAKE_INSTALL_PREFIX="${install_dir}" \
-DCMAKE_TOOLCHAIN_FILE="${VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake" \
-DVCPKG_TARGET_TRIPLET="${VCPKG_TARGET_TRIPLET}" \
-Dxsimd_SOURCE=BUNDLED
Comment thread
jbonofre marked this conversation as resolved.
Outdated
cmake --build "${build_dir}/cpp"
cmake --install "${build_dir}/cpp"
github_actions_group_end
Expand Down
2 changes: 1 addition & 1 deletion gandiva/src/main/cpp/jni_common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ DataTypePtr ProtoTypeToDataType(const gandiva::types::ExtGandivaType& ext_type)
return arrow::date64();
case gandiva::types::DECIMAL:
// TODO: error handling
return arrow::decimal(ext_type.precision(), ext_type.scale());
return arrow::decimal128(ext_type.precision(), ext_type.scale());
case gandiva::types::TIME32:
return ProtoTypeToTime32(ext_type);
case gandiva::types::TIME64:
Expand Down
Loading