test: improve typescript-based test framework #12226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
bzp2010
changed the title
bzp2010
requested review from
membphis,
nic-6443,
moonming,
Baoyuantop,
LiteSun,
Revolyssup,
SkyeYoung,
guoqqqi and
AlinsRan
dosubot
bot
added
size:L
juzhiyuan
approved these changes
May 19, 2025
SkyeYoung
reviewed
May 19, 2025
| url: `http://127.0.0.1:1984/${uri}`, | ||
| data: body, | ||
| headers: { | ||
| 'X-API-KEY': 'edd1c9f034335f136f87ad84b625c8f1', |
There was a problem hiding this comment.
can we pick it from apisix config?
There was a problem hiding this comment.
It could be. But the hardcoded ones seem to be sufficient for now.
This is because this server is spawned by test nginx and not by the new test framework itself (it doesn't even use the standard APISIX startup process), which sucks and will be improved later so that ts test can autonomously start or stop APISIX instances (right now it has to rely on a xxx.t "shell" file to boot)
Baoyuantop
approved these changes
May 19, 2025
guoqqqi
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split from #12196, modifications in functionality and testing frameworks were introduced there, making those PR not pure.
First we can merge this PR, after that rebase that PR, we can make that PR to focus on the function, also easy to backport.
Checklist