Skip to content

test: merge separately http3 cases #12223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025

Conversation

bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented May 16, 2025

Description

APISIX workflow now tests HTTP3 and other cases separately, which results in more than double the number of workflows, more time-consuming, and more error possibilities.
Given that ngx http3 has been added to the (openresty's) default build since openresty 1.27, and apisix-runtime has long had it as a default build module, I think they can be merged in one place.

This PR aims to remove the separate http3 tests and reduce our mental overhead.

In addition to this, this PR also reduces the time required by a small amount by simply reordering the workflow execution.
Technically, the original workflow started all the required external components at the beginning, such as kafka, etc., which would have consumed some resources and undoubtedly slowed down the subsequent builds of the apisix-runtime, thus slowing down the overall time-consumption. This order has been adjusted to build first, then start the external components.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@bzp2010 bzp2010 changed the title chore: merge separately http3 test test: merge separately http3 cases May 16, 2025
@bzp2010 bzp2010 marked this pull request as ready for review May 17, 2025 04:15
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code labels May 17, 2025
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bzp2010 bzp2010 merged commit 694607d into apache:master May 19, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants