-
Notifications
You must be signed in to change notification settings - Fork 2.6k
test: merge separately http3 cases #12223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+20
−235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juzhiyuan
approved these changes
May 17, 2025
moonming
approved these changes
May 17, 2025
Baoyuantop
approved these changes
May 19, 2025
AlinsRan
approved these changes
May 19, 2025
membphis
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github_actions
Pull requests that update GitHub Actions code
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
APISIX workflow now tests HTTP3 and other cases separately, which results in more than double the number of workflows, more time-consuming, and more error possibilities.
Given that ngx http3 has been added to the (openresty's) default build since openresty 1.27, and apisix-runtime has long had it as a default build module, I think they can be merged in one place.
This PR aims to remove the separate http3 tests and reduce our mental overhead.
In addition to this, this PR also reduces the time required by a small amount by simply reordering the workflow execution.
Technically, the original workflow started all the required external components at the beginning, such as kafka, etc., which would have consumed some resources and undoubtedly slowed down the subsequent builds of the apisix-runtime, thus slowing down the overall time-consumption. This order has been adjusted to build first, then start the external components.
Checklist