-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: consumer key duplication check #12040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Baoyuantop
wants to merge
25
commits into
apache:master
Choose a base branch
from
Baoyuantop:feat-unique-key
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
ce80722
feat: consumer key duplication check
Baoyuantop 489a985
fix: improve code logic
Baoyuantop a3a4ac2
fix: lint
Baoyuantop fa3caa8
test: add test case
Baoyuantop ef0a8ea
fix: format code
Baoyuantop 80ce431
fix: format code
Baoyuantop 93a4b63
fix: test
Baoyuantop 5e0fe0f
fix: lint code
Baoyuantop 5660ad2
fix: test
Baoyuantop 6cb6b78
fix: add log
Baoyuantop 02daa2c
fix: format code
Baoyuantop 3b2aa93
update
Baoyuantop 7d2d930
fix: test
Baoyuantop 7fe1827
fix: lint code
Baoyuantop 38430a0
fix: remove error log
Baoyuantop 95c2a92
fix: update code
Baoyuantop de68197
fix: lint
Baoyuantop b5efe91
fix: update code
Baoyuantop f5f883d
fix: update
Baoyuantop e3af265
fix: update
Baoyuantop 3717039
update
Baoyuantop 07b2eca
fix: merge function
Baoyuantop 9caab8f
fix: lint code
Baoyuantop 74d4219
fix: adjust function position
Baoyuantop 5a528fa
fix
Baoyuantop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -314,3 +314,5 @@ GET /t | |
} | ||
--- response_body | ||
all done | ||
--- error_log | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The testing of these changes is an expected change. These tests have an admin api call to the consumer and use a non-existent secret reference, which in the new logic triggers a secret lookup failure and an error log. It didn't break the original test path. |
||
failed to fetch secret value: no secret conf, secret_uri: $secret://aws/mysecret/jack/key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding the duplicate judgment, it cannot be added here again, so I made a modification.