This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Refactor of replacement function #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodinokov
reviewed
Sep 26, 2020
| if r.Source.MultiRef != nil { | ||
| count += 1 | ||
| } | ||
| // @aodinokov, Should it be equal 1? |
There was a problem hiding this comment.
I think we should report error when more than 1 contradicting fields are set.
> 1 is right
aodinokov
reviewed
Sep 26, 2020
| return s.MultiRef.prepareValue(items) | ||
| } | ||
| // @aodinokov, Should it be an error? | ||
| return "", nil |
There was a problem hiding this comment.
It may be even panic :)
probably it should be handled in 'validate' function.
and in that case this error will never happen here
aodinokov
reviewed
Sep 26, 2020
| return "", nil | ||
| } | ||
|
|
||
| func (f Function) Exec(items []*yaml.RNode) error { |
There was a problem hiding this comment.
BTW,
in the last incarnations of plugins I started to call this as Filter function with a bit different signature:
https://github.com/aodinokov/kpt-functions-catalog/blob/function-with-env/functions/go/templater/function/filter.go#L42
this is to match kyaml interface Filter. in that case it's also possilble to use these functions from code inside kyaml filters.
probably something to think about
aodinokov
force-pushed
the
master
branch
25 times, most recently
from
5ecbce9 to
a029bf0
Compare
aodinokov
force-pushed
the
master
branch
9 times, most recently
from
646c32f to
6c6c1ea
Compare
aodinokov
force-pushed
the
master
branch
3 times, most recently
from
d46169b to
2f0c1ad
Compare
aodinokov
force-pushed
the
master
branch
11 times, most recently
from
68c9c67 to
98b8ae6
Compare
aodinokov
force-pushed
the
master
branch
2 times, most recently
from
0f0197b to
0e2e126
Compare
aodinokov
force-pushed
the
master
branch
2 times, most recently
from
a2637ad to
17cf153
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.