transaction-bench: add integration test#37
Open
KirillLykov wants to merge 2 commits intoanza-xyz:masterfrom
Open
transaction-bench: add integration test#37KirillLykov wants to merge 2 commits intoanza-xyz:masterfrom
KirillLykov wants to merge 2 commits intoanza-xyz:masterfrom
Conversation
fkouteib
reviewed
Mar 23, 2026
Contributor
fkouteib
left a comment
fkouteib
left a comment
There was a problem hiding this comment.
overall lgtm. couple minor comments
| for _ in 0..10 { | ||
| receiver.try_iter().for_each(|response| { | ||
| if let Some(err) = response.value.err { | ||
| // sometimes block is not ready, see issues/33462 |
Contributor
There was a problem hiding this comment.
This should use a full agave (?) url here
| workers_pull_size: 1, | ||
| send_fanout: 1, | ||
| compute_unit_price: Some(100), | ||
| leader_tracker: LeaderTracker::PinnedLeaderTracker { address: tpu_addr }, //LeaderTracker::WsLeaderTracker, |
Contributor
There was a problem hiding this comment.
remove commented/dead code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration test and extract
run_clientfunction from the main.rs into separate module so that it is possible to use for integration test.