Skip to content

make std optional in solana-msg #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kevinheavey
Copy link
Contributor

@kevinheavey kevinheavey commented Mar 30, 2025

In a follow-up PR I'd like to move sol_log_data here as I noticed it gets used in a few places

Note: this is a breaking change

@joncinque joncinque requested a review from febo March 31, 2025 19:26
febo
febo previously approved these changes Apr 1, 2025
Copy link
Contributor

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joncinque joncinque added the breaking PR contains breaking changes label Apr 1, 2025
@kevinheavey kevinheavey force-pushed the solana-msg-std-optional branch from 7bda419 to 62b7a9f Compare April 2, 2025 09:21
@febo febo self-requested a review April 3, 2025 16:32
@febo febo dismissed their stale review April 3, 2025 16:34

Waiting for patch releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking PR contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants