block component: introduce wincode #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksn6
requested review from
AshwinSekar,
bw-solana,
carllin,
cpubot and
wen-coding
ksn6
force-pushed
the
block-component-via-wincode
branch
from
0c03888 to
cd6a2f7
Compare
ksn6
force-pushed
the
block-component-via-wincode
branch
from
cd6a2f7 to
ec10bcf
Compare
cpubot
reviewed
Dec 1, 2025
Contributor
cpubot
left a comment
cpubot
left a comment
There was a problem hiding this comment.
A few suggestions, and a question about LengthPrefixed. Will have more follow-up after I understand LengthPrefixed -- it probably shouldn't use SeqLen.
cpubot
reviewed
Dec 1, 2025
cpubot
reviewed
Dec 1, 2025
ksn6
force-pushed
the
block-component-via-wincode
branch
from
6683bdd to
b554bed
Compare
cpubot
reviewed
Dec 2, 2025
ksn6
added a commit
that referenced
this pull request
Dec 4, 2025
#### Problem and Summary of Changes PR #615 introduced `block_component_v2.rs`, which: - Is identical to `block_component.rs` from a functionality standpoint (demonstrated via tests) - Is written via `wincode`, resulting in far cleaner logic This PR: - Moves the contents of `block_component_v2.rs` into `block_component.rs`, removing the old `BlockComponent` implementation - Updates call-sites (all cosmetic changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem and Summary of Changes
block_component.rsis getting hard to manage. Let's usewincodeto solve this.Notes:
block_component_v2.rsnow has close to zero custom serde code, and is much simpler to maintain. We have tests to validate that behavior identically matches that ofblock_component.rs.Once this lands, we'll entirely remove
block_component.rs.This PR does not use
wincodeto serdeEntryBatch-es just yet. We'll do this as soon as we upstream toagave. I tried cherry-picking the PRs to getEntryto implementSchemaRead/SchemaWrite, but ran into some versioning problems. Could probably get this to work with some effort, but there's no point, since we'll be upstreaming soon anyways.