Remove usages of WritableAccount::create
#9279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9279 +/- ##
=========================================
- Coverage 82.6% 82.6% -0.1%
=========================================
Files 890 890
Lines 320722 320797 +75
=========================================
- Hits 265085 265064 -21
- Misses 55637 55733 +96 🚀 New features to boost your workflow:
|
LucasSte
requested review from
2501babe,
Lichtso,
brooksprumo and
buffalojoec
buffalojoec
approved these changes
Nov 26, 2025
| let decoded_account = encoded_account.to_account_shared_data().unwrap(); | ||
| assert_eq!(decoded_account.data(), &vec![0; 1024]); | ||
| let decoded_account = encoded_account.decode::<AccountSharedData>().unwrap(); | ||
| let decoded_account = encoded_account.to_account().unwrap(); |
There was a problem hiding this comment.
It doesn't really matter, but these are flipped.
Lichtso
approved these changes
Nov 26, 2025
|
Reference back to related first PR: #8668 |
AvhiMaz
pushed a commit
to AvhiMaz/agave
that referenced
this pull request
Nov 28, 2025
Remove usages of fn create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to remove
fn createfromtrait WritableAccount, since program-runtime has adopted an account interface that contains references and cannot be created with owned types like those offn create's signature.Following the discussion in anza-xyz/solana-sdk#456 (review), we will replace
WritableAccount::createbyAccountSharedData::create_from_existing_shared_dataforAccountSharedData, andAccountinstances will be initialized directly since all its members are public.Summary of Changes
WritableAccount::createbyAccountSharedData::create_from_existing_shared_dataforAccountSharedData.Accountdirectly.