Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converted all path coordinates to numeric values for Checkbox component #338

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Converted all path coordinates to numeric values for Checkbox component #338

wants to merge 3 commits into from

Conversation

TheStarkster
Copy link

Following changes are made to checkbox component

  • Converted all path coordinates to numeric values.
  • Appended the checkmark path as a sibling of the rect (within the same parent group), not inside it.
  • Added fill: 'none' to the checkmark path to ensure the stroke-only checkmark is visible.

@hustcc hustcc requested a review from Aarebecca December 17, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aarebecca Aarebecca Awaiting requested review from Aarebecca

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheStarkster