Skip to content

refactor: 兼容不支持less的项目 #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

refactor: 兼容不支持less的项目 #3181

wants to merge 4 commits into from

Conversation

Alexzjt
Copy link
Contributor

@Alexzjt Alexzjt commented May 30, 2025

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels May 30, 2025
Copy link
Contributor

你好 @Alexzjt,非常感谢你的贡献.
为了让代码更健壮, 请根据 贡献指南 补充相应单元测试 (文档改动或其他特殊场景除外), 如果有 API 改动, 请修改 相应的文档.
同时请检查 linttest 相关 CI 是否通过, 如果失败, 请点击 [Details] 按钮查看, 并根据日志修复.

Hello, @Alexzjt, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.
At the same time, please check whether the CI related to lint and test passes. If the CI fails, please click [Details] button to check and repair according to the log.

Copy link

Walkthrough

This pull request addresses compatibility issues for projects that do not support Less by refactoring the tooltip styling from Less to CSS. It resolves issues #3088 and #3148 by ensuring that the tooltip styles are correctly applied without relying on Less-specific features.

Changes

Files Summary
package.json Updated dependencies to reflect changes in styling approach.
index.less (shared/styles/tooltip) Modified import statements to align with new styling approach.
index.css (ui/tooltip) Introduced new CSS file for tooltip styling, replacing Less.
index.less (ui/tooltip) Removed old Less file and its contents.
index.ts (ui/tooltip) Updated import statement to use CSS instead of Less.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (ecdc9c8) to head (ed9ae59).
Report is 679 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3181      +/-   ##
==========================================
+ Coverage   75.77%   79.86%   +4.09%     
==========================================
  Files         257      217      -40     
  Lines       11994    11925      -69     
  Branches     2464     2669     +205     
==========================================
+ Hits         9088     9524     +436     
+ Misses       1398      793     -605     
- Partials     1508     1608     +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented May 30, 2025

Size Change: -899 B (-0.14%)

Total Size: 627 kB

Filename Size Change
./packages/s2-react/dist/s2-react.min.css 1.3 kB -441 B (-25.33%) 🎉
./packages/s2-vue/dist/s2-vue.min.css 1.59 kB -458 B (-22.33%) 🎉
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/s2-extends.min.js 158 kB
./packages/s2-core/dist/s2.min.css 581 B
./packages/s2-core/dist/s2.min.js 262 kB
./packages/s2-react-components/dist/s2-react-components.min.css 2.55 kB
./packages/s2-react-components/dist/s2-react-components.min.js 124 kB
./packages/s2-react/dist/s2-react.min.js 38.3 kB
./packages/s2-vue/dist/s2-vue.min.js 38.3 kB

compressed-size-action

@Alexzjt Alexzjt changed the title fix: 兼容不支持less的项目 refactor: 兼容不支持less的项目 May 30, 2025
@github-actions github-actions bot added pr(refactor) refactor and removed pr(fix) bug fix labels May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(refactor) refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛没有使用 less-loader 的项目中编译失败
2 participants