fix: 评审问题

antvis · Nov 8, 2023 · b25e160 · b25e160
1 parent 5f33e01
commit b25e160
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 12 deletions.
diff --git a/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/index.tsx b/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/index.tsx
@@ -1,4 +1,3 @@
-// @ts-ignore
 import { implementLayer } from '@antv/li-sdk';
 import React from 'react';
 import component from './Component';

diff --git a/...ages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/domain-collapse.ts b/...ages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/domain-collapse.ts
@@ -1,6 +1,4 @@
-import type { FieldSelectOptionType } from '@antv/li-p2';
-
-export default (fieldList: FieldSelectOptionType[]) => {
+export default () => {
   return {
     type: 'void',
     'x-component': 'FormCollapse',
@@ -26,7 +24,7 @@ export default (fieldList: FieldSelectOptionType[]) => {
             'x-component-props': {
               min: -Infinity,
               max: Infinity,
-              sliderVisible: false,
+              showSlider: false,
             },
           },
 

diff --git a/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/index.ts b/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/index.ts
@@ -1,5 +1,4 @@
 import type { RasterLayerProps } from '@antv/larkmap';
-// @ts-ignore
 import type { LayerRegisterForm, LayerRegisterFormProps, LayerRegisterFormResultType } from '@antv/li-sdk';
 import getSchema from './schema';
 
@@ -73,7 +72,7 @@ const fromValues = (
 
 export default (props: LayerRegisterFormProps): LayerRegisterForm<SingleBandRasterLayerStyleAttributeValue> => {
   // 属性面板表单的 Schema 定义，来自表单库 formily 的 Schema
-  const schema = getSchema(props.datasetFields);
+  const schema = getSchema();
   return {
     schema,
     toValues,

diff --git a/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/schema.ts b/packages/li-analysis-assets/src/layers/SingleBandRasterLayer/register-form/schema.ts
@@ -1,9 +1,9 @@
 import otherAttributesCollapse from '@antv/li-p2/dist/esm/LayerAttribute/common-schema/other-attributes-collapse';
 import domainCollapse from './domain-collapse';
 
-export default (fieldList: any) => {
+export default () => {
   return {
-    collapseItem_domain: domainCollapse(fieldList),
+    collapseItem_domain: domainCollapse(),
     collapseItem_style: {
       type: 'void',
       'x-component': 'FormCollapse',

diff --git a/packages/li-p2/src/components/Formily/SliderRange/index.tsx b/packages/li-p2/src/components/Formily/SliderRange/index.tsx
@@ -14,12 +14,12 @@ const defaultConfig = {
 };
 
 type InternalSliderRangeProps = SliderRangeProps & {
-  sliderVisible: boolean;
+  showSlider?: boolean;
 };
 
 const InternalSliderRange: React.FC<InternalSliderRangeProps> = (props) => {
   const prefixCls = usePrefixCls('formily-slider-range', props);
-  const { sliderVisible = true, ...otherProps } = props;
+  const { showSlider = true, ...otherProps } = props;
   const [wrapSSR, hashId] = useStyle(prefixCls);
   const config = { ...defaultConfig, ...otherProps };
   const range = isArray(props.value) ? props.value : props.defaultValue || [0, 100];
@@ -30,7 +30,7 @@ const InternalSliderRange: React.FC<InternalSliderRangeProps> = (props) => {
 
   return wrapSSR(
     <div className={cls(`${prefixCls}`, hashId)}>
-      {sliderVisible && (
+      {showSlider && (
         <AntdSlider
           {...config}
           range={true}