Skip to content

Keep LineBreaks in pasted code #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep LineBreaks in pasted code #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions codejar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P
addClosing: true,
history: true,
window: globalWindow,
autoclose: {
open: `([{'"`,
autoclose: {
open: `([{'"`,
close: `)]}'"`
},
...opt,
Expand Down Expand Up @@ -149,9 +149,9 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P

function save(): Position {
const s = getSelection()
const pos: Position = {start: 0, end: 0, dir: undefined}
const pos: Position = { start: 0, end: 0, dir: undefined }

let {anchorNode, anchorOffset, focusNode, focusOffset} = s
let { anchorNode, anchorOffset, focusNode, focusOffset } = s
if (!anchorNode || !focusNode) throw 'error1'

// If the anchor and focus are the editor element, return either a full
Expand Down Expand Up @@ -223,7 +223,7 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P

// Flip start and end if the direction reversed
if (pos.dir == '<-') {
const {start, end} = pos
const { start, end } = pos
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep style as is for now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this change, that was not intended.

pos.start = end
pos.end = start
}
Expand Down Expand Up @@ -381,7 +381,7 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P
const pos = save()
// Remove full length tab or just remaining padding
const len = Math.min(options.tab.length, padding.length)
restore({start, end: start + len})
restore({ start, end: start + len })
document.execCommand('delete')
pos.start -= len
pos.end -= len
Expand Down Expand Up @@ -430,7 +430,7 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P
}

at++
history[at] = {html, pos}
history[at] = { html, pos }
history.splice(at + 1)

const maxHistory = 300
Expand Down Expand Up @@ -511,6 +511,7 @@ export function CodeJar(editor: HTMLElement, highlight: (e: HTMLElement, pos?: P
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#039;')
.replace(/\n/g, '<br>')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about not-ff? Ib those plain-text mode \n is supported.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, this problem exists only using FF. I now can confirm that pasting multiline code works without problems using Edge or Chrome.

document.execCommand('insertHTML', false, text)
}

Expand Down