Implement Node streaming support#683
Open
markerikson wants to merge 7 commits intoantoniomuso:mainfrom
Open
Conversation
antoniomuso
force-pushed
the
feat/upgrade-napi-and-code
branch
9 times, most recently
from
b7d661c to
f5ab119
Compare
markerikson
force-pushed
the
feat/node-streaming
branch
from
26ad2de to
c8613ca
Compare
Author
|
Rebased this on top of the merged changes from #682 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #429 (comment) , this PR contains AI-generated code (with human tweaks) to implement Node streaming support:
package.jsonto change the generated bindings filenames fromindex.js/.d.tstonativeBindings.js/.d.ts, to allow imports into the later stream JS files without circular import issuesindexfiles tonativeBindings, and added newindexfiles that re-export everythingnode-lz4index.spec.tsto verify the streaming implementation worksnode-lz4andlz4-napibehaviorI can't guarantee all of this is 100% correct, and Claude at one point got confused over whether the streaming classes should use an "accumulate-then-compress" approach or a "true streaming" approach. The current implementation appears to use "accumulate-then-compress".
Hopefully this is at least useful as a baseline for implementing, if not actually usable on its own!