feat: add Tdengine parser and examples #4614
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migrate from the parse module of TDengine. Signed-off-by: zhouyx <[email protected]>
|
You might want to check the ambiguity and parse tree result for some of your tests. Here are all the possible parse trees for select.sql. There's ambiguity in columnReference because "ts" in line 3 of select.sql can be either a columnName or columnAlias because both can match NK_ID. The other ambiguity is with commonExpression/exprOrSubquery and commonExpression/booleanValueExpression. The ambiguity is detected in select.sql in line 5, with the expression after the "WHERE". The problem here is that you're trying to enter into an exprOrSubquery, but that references expression. This type of problem occurs in other grammars, but I haven't figured out a good way to split up an Antlr optimized left-recursive expression. You might want to include a readme.md so we can see where this is all coming from. |
|
Thank you for the review. I will try to resolve the ambiguity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate from the parse module of TDengine.