Fix Windows RecursionError in temporary directory cleanup #21

yeabwang · 2025-08-10T09:18:50Z

Problem

Windows filesystem operations were causing RecursionError in 5 workflow integration tests due to infinite recursion in shutil.rmtree() during temporary directory cleanup.

Solution

Multiple fallback cleanup strategies with recursion protection
Drop-in replacement for tempfile.TemporaryDirectory
Automatic monkey patching on Windows platforms
Cross-platform adapter pattern for filesystem operations
Added additional tests to test suite for the fix
Full test suite passing on Windows

- Add WindowsFileSystemCleaner class with multiple fallback strategies - Implement safe_rmtree with recursion protection (max depth 100) - Add retry logic for transient Windows filesystem errors - Support for locked files, permissions, and long path issues - Include safe temporary directory creation helpers Fixes RecursionError in Windows temporary directory cleanup operations.

- Add safe_temp_directory context manager with platform-aware cleanup - Implement SafeTemporaryDirectory as drop-in replacement for tempfile.TemporaryDirectory - Support custom prefixes, suffixes, and error handling options - Compatible interface with existing tempfile.TemporaryDirectory usage - Automatic cleanup using platform-specific safe removal methods Provides Windows-safe temporary directory management without code changes.

- Implement WindowsPatches class for automatic monkey patching - Replace tempfile.TemporaryDirectory with SafeTemporaryDirectory on Windows - Add context manager for temporary patch application - Auto-apply patches on module import for maximum compatibility - Provide manual patch control with apply/remove methods Enables transparent Windows filesystem fixes without modifying existing code.

- Add safe_rmtree method to PlatformAdapter class - Integrate Windows cleanup utilities for Windows platforms - Add create_safe_tempdir method with platform-specific handling - Maintain fallback to standard operations on non-Windows platforms - Extend platform adapter pattern to cover filesystem operations Completes cross-platform filesystem compatibility layer.

- Auto-apply Windows compatibility patches when claudecode module is imported - Graceful fallback if Windows patches are not available - Transparent activation without requiring code changes - Ensures maximum compatibility across all usage patterns Completes non-invasive Windows RecursionError fix implementation.

- Add 18 pytest tests covering all Windows cleanup functionality - Test platform detection, safe temp operations, context managers - Validate SafeTemporaryDirectory class behavior and error handling - Include Windows-specific functionality and cross-platform compatibility - Add performance and reliability tests with recursion protection - Provide integration test for complete workflow validation Ensures robust testing of Windows RecursionError fixes (191 total tests).

Copilot

Pull Request Overview

This PR fixes a critical Windows filesystem issue where RecursionError was occurring in 5 workflow integration tests during temporary directory cleanup, caused by infinite recursion in shutil.rmtree().

The solution implements a comprehensive cross-platform adapter pattern with multiple fallback cleanup strategies:

Windows-specific cleanup utilities with recursion protection
Drop-in replacement for tempfile.TemporaryDirectory
Automatic monkey patching on Windows platforms
Additional test coverage for the fix

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`claudecode/windows_patches.py`	Monkey-patching framework for Windows compatibility with auto-application on import
`claudecode/windows_cleanup.py`	Windows filesystem cleanup utilities with recursion protection and multiple fallback strategies
`claudecode/test_windows_cleanup.py`	Comprehensive test suite for Windows cleanup functionality
`claudecode/test_utils.py`	Enhanced test utilities with Windows-specific testing capabilities
`claudecode/safe_temp.py`	Platform-aware temporary directory management as drop-in replacement
`claudecode/platform_utils.py`	Cross-platform adapter for handling OS-specific command execution and filesystem operations
`claudecode/github_action_audit.py`	Updated to use platform adapter for Claude CLI execution
`claudecode/__init__.py`	Auto-applies Windows patches on module import
`README.md`	Added Windows setup and troubleshooting documentation

Copilot · 2025-08-10T09:20:11Z

claudecode/windows_patches.py

+    """
+    Manager for Windows-specific monkey patches.
+    
+    Handles  patching to fix Windows filesystem issues


Extra space in comment. Should be 'Handles patching' instead of 'Handles patching'.

Suggested change

Handles patching to fix Windows filesystem issues

Handles patching to fix Windows filesystem issues

Copilot · 2025-08-10T09:20:12Z

claudecode/windows_cleanup.py

+        Args:
+            max_retries: Retry attempts for locked files
+            retry_delay: Delay between retries (seconds)
+            max_depth: Max directory depth (prevents infinite recursion)


[nitpick] The magic number 100 for max_depth should be documented or made configurable. Consider adding a constant or explaining why 100 is the appropriate recursion limit.

Suggested change

max_depth: Max directory depth (prevents infinite recursion)

def __init__(self, max_retries: int = 3, retry_delay: float = 0.1, max_depth: int = DEFAULT_MAX_DEPTH):

"""

Args:

max_retries: Retry attempts for locked files

retry_delay: Delay between retries (seconds)

max_depth: Max directory depth (prevents infinite recursion, default: DEFAULT_MAX_DEPTH)

Copilot · 2025-08-10T09:20:12Z

README.md

+
+1. Install Node.js (v18 or later) and npm:
+  - Download from https://nodejs.org or use nvm-windows.
+2. Install the Claude CLI:npm install -g @anthropic-ai/claude-code


Missing space after colon. Should be '2. Install the Claude CLI: npm install -g @anthropic-ai/claude-code'.

Suggested change

2. Install the Claude CLI:npm install -g @anthropic-ai/claude-code

2. Install the Claude CLI: npm install -g @anthropic-ai/claude-code

Copilot · 2025-08-10T09:20:12Z

README.md

+[Environment]::SetEnvironmentVariable("Path", [Environment]::GetEnvironmentVariable("Path", "User") + ";$npmPath", "User")
+
+4. Set PowerShell execution policy:Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned
+5. Verify installation:claude --version


Missing space after colon. Should be '3. Add npm global directory to PATH: $npmPath = npm config get prefix'.

Suggested change

5. Verify installation:claude --version

2. Install the Claude CLI: npm install -g @anthropic-ai/claude-code

3. Add npm global directory to PATH: $npmPath = npm config get prefix

[Environment]::SetEnvironmentVariable("Path", [Environment]::GetEnvironmentVariable("Path", "User") + ";$npmPath", "User")

4. Set PowerShell execution policy: Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned

5. Verify installation: claude --version

Copilot · 2025-08-10T09:20:13Z

README.md

+3. Add npm global directory to PATH:$npmPath = npm config get prefix
+[Environment]::SetEnvironmentVariable("Path", [Environment]::GetEnvironmentVariable("Path", "User") + ";$npmPath", "User")
+
+4. Set PowerShell execution policy:Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned


Missing space after colon. Should be '4. Set PowerShell execution policy: Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned'.

Suggested change

4. Set PowerShell execution policy:Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned

4. Set PowerShell execution policy: Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned

Copilot · 2025-08-10T09:20:13Z

README.md

+[Environment]::SetEnvironmentVariable("Path", [Environment]::GetEnvironmentVariable("Path", "User") + ";$npmPath", "User")
+
+4. Set PowerShell execution policy:Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned
+5. Verify installation:claude --version


Missing space after colon. Should be '5. Verify installation: claude --version'.

Suggested change

5. Verify installation:claude --version

5. Verify installation: claude --version

Copilot · 2025-08-10T09:20:13Z

README.md

+
+Expected output: 1.0.71 (Claude Code) or similar.
+
+Troubleshooting


The 'Troubleshooting' section should be formatted as a proper header with markdown syntax (## Troubleshooting).

Suggested change

Troubleshooting

## Troubleshooting

yeabwang added 8 commits August 9, 2025 14:47

Fix Claude CLI execution on Windows with PlatformAdapter

2c9dd46

class renaming for pytest auto discovery warnings

ebd0dfe

Copilot AI review requested due to automatic review settings August 10, 2025 09:18

Copilot AI reviewed Aug 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Windows RecursionError in temporary directory cleanup #21

Fix Windows RecursionError in temporary directory cleanup #21

Uh oh!

yeabwang commented Aug 10, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Copilot AI Aug 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	Handles patching to fix Windows filesystem issues
	Handles patching to fix Windows filesystem issues

	2. Install the Claude CLI:npm install -g @anthropic-ai/claude-code
	2. Install the Claude CLI: npm install -g @anthropic-ai/claude-code

-. Verify installation:claude --version
+. Install the Claude CLI: npm install -g @anthropic-ai/claude-code
+. Add npm global directory to PATH: $npmPath = npm config get prefix
+[Environment]::SetEnvironmentVariable("Path", [Environment]::GetEnvironmentVariable("Path", "User") + ";$npmPath", "User")
+. Set PowerShell execution policy: Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned
+. Verify installation: claude --version

	4. Set PowerShell execution policy:Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned
	4. Set PowerShell execution policy: Set-ExecutionPolicy -Scope CurrentUser -ExecutionPolicy RemoteSigned

	5. Verify installation:claude --version
	5. Verify installation: claude --version


		Expected output: 1.0.71 (Claude Code) or similar.

		Troubleshooting

Fix Windows RecursionError in temporary directory cleanup #21

Are you sure you want to change the base?

Fix Windows RecursionError in temporary directory cleanup #21

Uh oh!

Conversation

yeabwang commented Aug 10, 2025

Problem

Solution

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant