Skip to content

test: isolate settings tests to use temporary directories #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashwin-ant merged 1 commit into from
Jul 17, 2025
Merged

test: isolate settings tests to use temporary directories #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/setup-claude-code-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@ import { $ } from "bun";
import { homedir } from "os";
import { readFile } from "fs/promises";

export async function setupClaudeCodeSettings(settingsInput?: string) {
const home = homedir();
export async function setupClaudeCodeSettings(
settingsInput?: string,
homeDir?: string,
) {
const home = homeDir ?? homedir();
const settingsPath = `${home}/.claude/settings.json`;
console.log(`Setting up Claude settings at: ${settingsPath}`);

Expand Down
42 changes: 26 additions & 16 deletions test/setup-claude-code-settings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,33 @@

import { describe, test, expect, beforeEach, afterEach } from "bun:test";
import { setupClaudeCodeSettings } from "../src/setup-claude-code-settings";
import { homedir } from "os";
import { tmpdir } from "os";
import { mkdir, writeFile, readFile, rm } from "fs/promises";
import { join } from "path";

const home = homedir();
const settingsPath = join(home, ".claude", "settings.json");
const testSettingsDir = join(home, ".claude-test");
const testHomeDir = join(
tmpdir(),
"claude-code-test-home",
Date.now().toString(),
);
const settingsPath = join(testHomeDir, ".claude", "settings.json");
const testSettingsDir = join(testHomeDir, ".claude-test");
const testSettingsPath = join(testSettingsDir, "test-settings.json");

describe("setupClaudeCodeSettings", () => {
beforeEach(async () => {
// Create test directory
// Create test home directory and test settings directory
await mkdir(testHomeDir, { recursive: true });
await mkdir(testSettingsDir, { recursive: true });
});

afterEach(async () => {
// Clean up test directory
await rm(testSettingsDir, { recursive: true, force: true });
// Clean up test home directory
await rm(testHomeDir, { recursive: true, force: true });
});

test("should always set enableAllProjectMcpServers to true when no input", async () => {
await setupClaudeCodeSettings();
await setupClaudeCodeSettings(undefined, testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -37,7 +42,7 @@ describe("setupClaudeCodeSettings", () => {
env: { API_KEY: "test-key" },
});

await setupClaudeCodeSettings(inputSettings);
await setupClaudeCodeSettings(inputSettings, testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -64,7 +69,7 @@ describe("setupClaudeCodeSettings", () => {

await writeFile(testSettingsPath, JSON.stringify(testSettings, null, 2));

await setupClaudeCodeSettings(testSettingsPath);
await setupClaudeCodeSettings(testSettingsPath, testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -80,7 +85,7 @@ describe("setupClaudeCodeSettings", () => {
model: "test-model",
});

await setupClaudeCodeSettings(inputSettings);
await setupClaudeCodeSettings(inputSettings, testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -90,15 +95,19 @@ describe("setupClaudeCodeSettings", () => {
});

test("should throw error for invalid JSON string", async () => {
expect(() => setupClaudeCodeSettings("{ invalid json")).toThrow();
expect(() =>
setupClaudeCodeSettings("{ invalid json", testHomeDir),
).toThrow();
});

test("should throw error for non-existent file path", async () => {
expect(() => setupClaudeCodeSettings("/non/existent/file.json")).toThrow();
expect(() =>
setupClaudeCodeSettings("/non/existent/file.json", testHomeDir),
).toThrow();
});

test("should handle empty string input", async () => {
await setupClaudeCodeSettings("");
await setupClaudeCodeSettings("", testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -107,7 +116,7 @@ describe("setupClaudeCodeSettings", () => {
});

test("should handle whitespace-only input", async () => {
await setupClaudeCodeSettings(" \n\t ");
await setupClaudeCodeSettings(" \n\t ", testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand All @@ -119,6 +128,7 @@ describe("setupClaudeCodeSettings", () => {
// First, create some existing settings
await setupClaudeCodeSettings(
JSON.stringify({ existingKey: "existingValue" }),
testHomeDir,
);

// Then, add new settings
Expand All @@ -127,7 +137,7 @@ describe("setupClaudeCodeSettings", () => {
model: "claude-opus-4-20250514",
});

await setupClaudeCodeSettings(newSettings);
await setupClaudeCodeSettings(newSettings, testHomeDir);

const settingsContent = await readFile(settingsPath, "utf-8");
const settings = JSON.parse(settingsContent);
Expand Down
Loading