Skip to content

Conversation

@y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Jan 5, 2026

cgi gem is removed from the default gems in Ruby 4.0. https://www.ruby-lang.org/en/news/2025/12/25/ruby-4-0-0-released/#stdlib-compatibility-issues

We need to add it as explicit dependency it because we use CGI.parse.

Fixes #147.

@y-yagi y-yagi marked this pull request as ready for review January 5, 2026 22:51
@y-yagi y-yagi requested a review from a team as a code owner January 5, 2026 22:51
`cgi` gem is removed from the default gems in Ruby 4.0.
https://www.ruby-lang.org/en/news/2025/12/25/ruby-4-0-0-released/#stdlib-compatibility-issues

We need to add it as explicit dependency it because we use `CGI.parse`.

Fixes anthropics#147.
@y-yagi y-yagi force-pushed the add_cgi_as_dependency branch from 7d15c9a to ea6ce3c Compare January 6, 2026 04:42
@ms-jpq
Copy link
Collaborator

ms-jpq commented Jan 9, 2026

thanks! this is nice!

@ms-jpq ms-jpq changed the base branch from main to next January 9, 2026 20:23
@ms-jpq ms-jpq changed the title Add cgi gem as explicit dependency chore: add cgi gem as explicit dependency Jan 9, 2026
@ms-jpq ms-jpq merged commit b9ef072 into anthropics:next Jan 9, 2026
@y-yagi y-yagi deleted the add_cgi_as_dependency branch January 9, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruby 4 compatibility issues

2 participants