fix(vertex): do not override custom http client when using vertex #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreynering
commented
Sep 25, 2025
vertex/vertex.go
Outdated
| sdkoption.WithBaseURL(baseURL), | ||
| sdkoption.WithMiddleware(middleware), | ||
| sdkoption.WithHTTPClient(client), | ||
| sdkoption.WithHTTPClient(&http.Client{Transport: transport}), |
Author
There was a problem hiding this comment.
We need a custom HTTP client here, but this package was essetially overriding it, making our custom client useless.
Here, I'm trying to combine both transports, but I'm sure yet if this is the best way to accomplish it. Seems to have worked well for us, though.
TODO: Handle scenario where Done!rc.HTTPClient is nil. (Probably fallback to the previous code).
andreynering
commented
Sep 25, 2025
andreynering
commented
Sep 25, 2025
Comment on lines
+113
to
+120
| default: | ||
| return nil, fmt.Errorf("vertex middleware does not support %s %s", r.Method, r.URL.Path) |
Author
There was a problem hiding this comment.
Looks like if we miss any path, we probably forgot something in the code. A good idea to error here?
andreynering
force-pushed
the
vertex-fixes
branch
from
57c96d3 to
5ee2923
Compare
andreynering
force-pushed
the
vertex-fixes
branch
2 times, most recently
from
7419bf6 to
7b952cd
Compare
andreynering
changed the title
andreynering
force-pushed
the
vertex-fixes
branch
from
7b952cd to
7b1c366
Compare
Author
|
@gcemaj I wonder if you can take a look at this when possible? We're using a fork in the meantime because we need this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using the
go-vcrlibrary to handle HTTP requests inside tests, and it gives you a custom HTTP transport, but the SDK also sets one. This PR combine both transports so they work together!