Skip to content

feat: update useXChat & XRequest & fix useXAgent's RequestFn onSuccess type #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 15, 2025

Conversation

kimteayon
Copy link
Collaborator

@kimteayon kimteayon commented Apr 11, 2025

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ⌨️ Accessibility improvement
  • ❓ Other (about what?)

useXAgent requestFn类型与XRequest 不一致,onSuccess如果是流需要返回数组,同时useXChat 在流的真实场景直接将onSuccess返回的数组set进了message,导致useXChat不可用。

🔗 Related Issues

前置PR:
#711

前置PR相关ISSUES:
#536
#436
#705
#690
#248

本次PR相关ISSUES:

#690

jin19980928 and others added 26 commits March 27, 2025 13:37
chore: sync feature to main branch
* docs(conversations): fix typo of group-sort demo

* test(conversations): update demo snap
* refactor: Update ActionButton.tsx

* test: add test case for disabled action button
* refactor: memo mergedContent

* refactor: memo avatarNode

* refactor: remove useDisplayData

* refactor: memo bubble list item

* refactor: add _key for MemoBubbleListItem

---------

Co-authored-by: afc163 <[email protected]>
Co-authored-by: Mickey <[email protected]>
* chore: sync .dumi files from ant-design

* fix use hooks

* fix link

* fix lint

* fix lint

* fix code block button

* fix code block button

* update

* update

* update

* Update components/bubble/index.en-US.md

* update

* useState => useRef

* load lottie-web async
Copy link
Contributor

coderabbitai bot commented Apr 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Apr 11, 2025

Preview is ready

Copy link

codecov bot commented Apr 11, 2025

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (3841352) to head (a36ba59).
Report is 1 commits behind head on feature.

Additional details and impacted files
@@             Coverage Diff             @@
##           feature     #725      +/-   ##
===========================================
+ Coverage    92.33%   92.37%   +0.04%     
===========================================
  Files           66       66              
  Lines         1487     1495       +8     
  Branches       400      404       +4     
===========================================
+ Hits          1373     1381       +8     
  Misses         114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

request: async ({ message }, { onSuccess, onError }) => {
await sleep();

mockSuccess = !mockSuccess;

if (mockSuccess) {
onSuccess(`Mock success return. You said: ${message}`);
onSuccess([`Mock success return. You said: ${message}`]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是 break change?

Copy link
Collaborator Author

@kimteayon kimteayon Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是之前类型写错了,x-request 的onSuccess本身就要返回数组的,结果mock的request全部没写对,导致接入真实模型有很多bug,但是数据处理层面已经做了兼容了,即使没有返回数组这样写也不会影响运行,demo还是按照准确的数据进行返回。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

内置x-request的类型:
image

自定义request类型:
image

目前已经把类型改统一了 并且兼容了之前如果使用了自定义request 没有返回数组的情况

@kimteayon kimteayon merged commit 515833c into ant-design:feature Apr 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants