Add multiple style tag to support client components #13
Conversation
we will have server and client components
There was a problem hiding this comment.
Pull Request Overview
This PR updates the logic for injecting styles to better support client components by allowing multiple style tags when needed.
- Changes the type of the inserted flag from boolean to string to compare with the extracted style text.
- Modifies the insertion check to compare against the current style text rather than a simple truthy value.
|
|
||
| useServerInsertedHTML(() => { | ||
| const styleText = extractStyle(cache, { plain: true }); | ||
|
|
||
| if (inserted.current) { | ||
| if (inserted.current === styleText) { |
There was a problem hiding this comment.
Using an empty string as the initial value for 'inserted' can cause the condition to be true when styleText is empty, potentially skipping the intended style insertion. Consider initializing 'inserted' to null or undefined to avoid a conflict with a valid empty styleText.
Copilot uses AI. Check for mistakes.
|
@MadCcc 有空看看 |
|
can confirm it fixed ant-design/ant-design#53736 |
|
There may be duplicate style inserted if only judge the styleText is same or not. |
We will have a case page.tsx is server or client components
This pull can fix these issues (page.tsx is a server component)
ant-design/ant-design#47122
ant-design/ant-design#47104
In this case, the first time only remaining some components, not enough
the second time also only remaining some components, not enough
That's why we need both.