Skip to content

Conversation

@skola-ansys
Copy link
Collaborator

@skola-ansys skola-ansys commented Oct 7, 2025

Description

**Added version check **

Checklist:

  • [] Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • [] Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • [] Generate documentation
  • [] Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • [] Check that test code coverage is at least 80% when Sherlock is running
  • [] Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 7, 2025
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.66%. Comparing base (2c53f13) to head (919da7b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   61.66%   61.66%           
=======================================
  Files          22       22           
  Lines        5982     6029   +47     
=======================================
+ Hits         3689     3718   +29     
- Misses       2293     2311   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skola-ansys skola-ansys changed the title Optimization/version check feat: Optimization version check Oct 14, 2025
@skola-ansys skola-ansys added this to the 2026 R1 milestone Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants