Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API: updateThermalMaps() #214

Merged
merged 7 commits into from
Feb 1, 2024
Merged

New API: updateThermalMaps() #214

merged 7 commits into from
Feb 1, 2024

Conversation

ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand requested a review from ansjmoody January 25, 2024 13:32
@ansjmoody ansjmoody merged commit 6b88e15 into main Feb 1, 2024
26 checks passed
@ansjmoody ansjmoody deleted the updateThermalMaps branch February 1, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants