Skip to content

Conversation

@moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Nov 6, 2025

Closes #2701.

@moe-ad moe-ad self-assigned this Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.42%. Comparing base (d5130b3) to head (f8b4658).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2732      +/-   ##
==========================================
- Coverage   84.51%   84.42%   -0.09%     
==========================================
  Files          92       92              
  Lines       10912    10916       +4     
==========================================
- Hits         9222     9216       -6     
- Misses       1690     1700      +10     

@moe-ad
Copy link
Contributor Author

moe-ad commented Nov 7, 2025

Quick test with this script provided on #2701:
image
image

Nice.

TODO: clean up the build script.

@moe-ad moe-ad force-pushed the feat/improve-typing-of-operators branch from d2aac3e to 2b51a62 Compare November 10, 2025 08:22
@moe-ad moe-ad marked this pull request as ready for review November 10, 2025 08:57
@moe-ad moe-ad requested a review from PProfizi November 10, 2025 10:27
@PProfizi
Copy link
Contributor

Quick test with this script provided on #2701: image image

Nice.

TODO: clean up the build script.

Hi Moe, that looks good but can we also clean-up the docstring description of accepted types for inpt? It still mentions a lit of irrelevant types.

@github-actions
Copy link
Contributor

Some tests with 'continue-on-error: true' have failed:

  • PyDPF-Post API tests on ubuntu-latest

Created by continue-on-error-comment

@PProfizi PProfizi merged commit 6dc6db5 into main Nov 12, 2025
44 of 45 checks passed
@PProfizi PProfizi deleted the feat/improve-typing-of-operators branch November 12, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly type operator inputs/outputs

4 participants