Skip to content

fix(any): fix cast of Any to DataSources #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 5, 2025
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jul 28, 2025

Solves #2486 by adding explicit support for cast from Any to DataSources

@PProfizi PProfizi requested a review from BClappe July 28, 2025 15:01
@PProfizi PProfizi self-assigned this Jul 28, 2025
@PProfizi PProfizi added the bug Something isn't working label Jul 28, 2025
@PProfizi PProfizi linked an issue Jul 28, 2025 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.18%. Comparing base (7db63f1) to head (c412f4f).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2487      +/-   ##
==========================================
- Coverage   84.19%   84.18%   -0.02%     
==========================================
  Files          91       91              
  Lines       10683    10685       +2     
==========================================
  Hits         8995     8995              
- Misses       1688     1690       +2     

@PProfizi PProfizi requested a review from a team as a code owner July 28, 2025 17:12
@PProfizi PProfizi requested a review from rafacanton July 30, 2025 13:33
@BClappe BClappe force-pushed the fix/cast_any_to_data_sources branch from 136a164 to 372cd9d Compare August 5, 2025 12:46
@PProfizi PProfizi merged commit f0a29e9 into main Aug 5, 2025
43 of 44 checks passed
@PProfizi PProfizi deleted the fix/cast_any_to_data_sources branch August 5, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataSources not handled when getting workflow topology
2 participants