Skip to content

test: add more tests to expand coverage #2087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025
Merged

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jul 7, 2025

Description

Expand coverage for product_instance.py and conversions.py

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard requested a review from a team as a code owner July 7, 2025 15:33
@RyanJWard RyanJWard self-assigned this Jul 7, 2025
@github-actions github-actions bot added the testing Anything related to tests label Jul 7, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (8572519) to head (c0f7e94).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   92.85%   93.66%   +0.81%     
==========================================
  Files         138      138              
  Lines        9990     9991       +1     
==========================================
+ Hits         9276     9358      +82     
+ Misses        714      633      -81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @RyanJWard - thanks for all these tests!

@RobPasMue RobPasMue enabled auto-merge (squash) July 8, 2025 06:41
@RobPasMue RobPasMue merged commit 9ba6307 into main Jul 8, 2025
45 checks passed
@RobPasMue RobPasMue deleted the test/expand_code_coverage_4 branch July 8, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants