Skip to content

feat: vertex references #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
Jul 7, 2025
Merged

feat: vertex references #2083

merged 40 commits into from
Jul 7, 2025

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Jul 1, 2025 •
edited
Loading

Description

  • added ability to get vertices from edges, faces, and bodies
  • added new class 'Vertex' as a sub-class of Point3D to hold unique ID and position
  • vertices are able to be added to NS
  • tested all new functionality

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

jacobrkerstetter and others added 22 commits June 23, 2025 12:44
@jacobrkerstetter
wip - client side impl of get_vertices
bfe7779
@jacobrkerstetter
added GetVertices method to edges
38a24e5 
simple test in place - wip
@jacobrkerstetter
added position property to Point3D
26d552f 
finished test to test locations
@jacobrkerstetter
added functionality for components to be sent to move_translate
44c6d85 
tested with a box
@pre-commit-ci
chore: auto fixes from pre-commit hooks
7dbbf00
@pyansys-ci-bot
chore: adding changelog file 2068.added.md [dependabot-skip]
6d05dc3
@jacobrkerstetter
added components to NS
5e99f81 
reverted changes to move_translate
@jacobrkerstetter
Merge branch 'feat/move_translate_components' of https://github.com/a…
a7429f4 
…nsys/pyansys-geometry into feat/move_translate_components
@pre-commit-ci
chore: auto fixes from pre-commit hooks
a28b463
@pyansys-ci-bot
chore: adding changelog file 2068.added.md [dependabot-skip]
d29102a
@jacobrkerstetter
added components to "get" for named selections
d025c32 
added a test to fetch components from NS
@jacobrkerstetter
Merge branch 'feat/move_translate_components' of https://github.com/a…
726434f 
…nsys/pyansys-geometry into feat/move_translate_components
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
06cd9ec 
… feat/edges_get_vertices
@jacobrkerstetter
Merge branch 'feat/move_translate_components' of https://github.com/a…
b7e539c 
…nsys/pyansys-geometry into feat/edges_get_vertices
@jacobrkerstetter
wip
5c6ce72
@jacobrkerstetter
wrap the components property for calls before 26.1
4c58a1d
@pre-commit-ci
chore: auto fixes from pre-commit hooks
8f43784
@jacobrkerstetter
Merge branch 'feat/move_translate_components' of https://github.com/a…
52d2d88 
…nsys/pyansys-geometry into feat/edges_get_vertices
@jacobrkerstetter
added vertices to NS
2ff61ee 
added vertices client side support on body + tested
@jacobrkerstetter
added vertices to NS
e3c0669 
added test for NS with vertices
@jacobrkerstetter
edited NamedSelectionImport.scdocx to have a few vertices in a new group
53867c4 
tested importing NS with vertices
@jacobrkerstetter
add get vertices and test for faces
19309a4
@jacobrkerstetter jacobrkerstetter self-assigned this Jul 1, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Jul 1, 2025
pyansys-ci-bot and others added 4 commits July 1, 2025 19:58
@pyansys-ci-bot
chore: adding changelog file 2083.added.md [dependabot-skip]
ca94926
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
7b9a8de 
… feat/edges_get_vertices

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/v0/named_selection.py
#	src/ansys/geometry/core/designer/design.py
#	src/ansys/geometry/core/designer/geometry_commands.py
#	src/ansys/geometry/core/designer/selection.py
@jacobrkerstetter
edited create return statement
1d5b696
@jacobrkerstetter
Merge branch 'feat/edges_get_vertices' of https://github.com/ansys/py…
064fb29 
…ansys-geometry into feat/edges_get_vertices
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review July 2, 2025 17:03
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner July 2, 2025 17:03
@github-actions github-actions bot added the maintenance Package and maintenance related label Jul 2, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.24390% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e88fafd). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/vertex.py 78.94% 4 Missing ⚠️
src/ansys/geometry/core/designer/body.py 87.50% 2 Missing ⚠️
src/ansys/geometry/core/designer/selection.py 85.71% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage        ?   92.85%           
=======================================
  Files           ?      138           
  Lines           ?     9990           
  Branches        ?        0           
=======================================
  Hits            ?     9276           
  Misses          ?      714           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot removed the maintenance Package and maintenance related label Jul 3, 2025
RobPasMue
RobPasMue requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments - but overall it's looking good, thanks @jacobrkerstetter!

RobPasMue
RobPasMue reviewed Jul 7, 2025
View reviewed changes
RobPasMue
RobPasMue approved these changes Jul 7, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome implementation @jacobrkerstetter

@jacobrkerstetter jacobrkerstetter merged commit ebdccf1 into main Jul 7, 2025
44 of 45 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/edges_get_vertices branch July 7, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobrkerstetter @RobPasMue @pyansys-ci-bot