-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implementation of inspect & repair geometry #1712
base: main
Are you sure you want to change the base?
Conversation
Implementation of inspect & repair geometry. Face and Edges are returned from message but they are reported only as ids because attempt to retrieve them causes circular dependencies and other issues with importing modules
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
==========================================
+ Coverage 90.94% 90.95% +0.01%
==========================================
Files 91 92 +1
Lines 8006 8082 +76
==========================================
+ Hits 7281 7351 +70
- Misses 725 731 +6 ☔ View full report in Codecov by Sentry. |
…s/pyansys-geometry into feat/inspect_repair_results
clean-up & add test
fix for pre-commit check
…s/pyansys-geometry into feat/inspect_repair_results
If needed we can add actual face object to the result of the inspect method but for now there is no use for it so we can just report the ids |
Let me pull your branch and do some local refactoring if you don't mind @smereu |
1) use grpc_id 2) Enum vs string 3) Make bodies optional argument for inspect and repair 4) Remove strings for some argument 5) Remove unused variable
change to adjust to core services order
Co-authored-by: Maxime Rey <[email protected]>
Description
Implementation of inspect & repair geometry.
The branch needs the latest version of the protos from the API server
Face and Edges are returned from message but they are reported only as ids because attempt to retrieve them causes circular dependencies and other issues with importing modules
The script below can be used to test the code
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder
)