Skip to content

FEAT: add create ports by nets function #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

HaiwenZhang
Copy link
Collaborator

@HaiwenZhang HaiwenZhang commented Jul 17, 2025

Description

Add create ports by nets function in HFSS3DLayout.

Issue linked

No issue

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@HaiwenZhang HaiwenZhang requested a review from a team as a code owner July 17, 2025 12:32
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Jul 17, 2025
@HaiwenZhang HaiwenZhang removed the enhancement New features or code improvements label Jul 17, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Jul 17, 2025
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

❌ Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.56%. Comparing base (ce0cb3b) to head (eff2e3c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6428       +/-   ##
===========================================
- Coverage   81.44%   23.56%   -57.88%     
===========================================
  Files         230      230               
  Lines       73726    73738       +12     
===========================================
- Hits        60044    17380    -42664     
- Misses      13682    56358    +42676     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @HaiwenZhang I left a minor comment to improve readability of the proposed changes. If that's fine with you, you can directly apply them from GitHub

@ansys-cla-bot
Copy link

ansys-cla-bot bot commented Jul 22, 2025

All Contributor License Agreement (CLA) signatures have been captured successfully. Thanks for contributing!

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last requested change, looks great otherwise. Thanks again for the contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants