-
Notifications
You must be signed in to change notification settings - Fork 173
FEAT: add create ports by nets function #6428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6428 +/- ##
===========================================
- Coverage 81.44% 23.56% -57.88%
===========================================
Files 230 230
Lines 73726 73738 +12
===========================================
- Hits 60044 17380 -42664
- Misses 13682 56358 +42676 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @HaiwenZhang I left a minor comment to improve readability of the proposed changes. If that's fine with you, you can directly apply them from GitHub
Updated style to improve readability Co-authored-by: Sébastien Morais <[email protected]>
All Contributor License Agreement (CLA) signatures have been captured successfully. Thanks for contributing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last requested change, looks great otherwise. Thanks again for the contribution !
Co-authored-by: Sébastien Morais <[email protected]>
Description
Add create ports by nets function in HFSS3DLayout.
Issue linked
No issue
Checklist