Skip to content

FIX: analyze_from_zero #6425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

FIX: analyze_from_zero #6425

wants to merge 18 commits into from

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Jul 17, 2025

Description

This PR fixes the bug in analyze_from_zero() method in maxwell.py.
The missing unit test of the will also be added in this PR.

Issue linked

Issue #6404

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@anur7 anur7 self-assigned this Jul 17, 2025
@anur7 anur7 added the bug Something isn't working label Jul 17, 2025
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Jul 17, 2025 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (ce0cb3b) to head (68b9d60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6425      +/-   ##
==========================================
+ Coverage   81.44%   82.42%   +0.98%     
==========================================
  Files         230      230              
  Lines       73726    73729       +3     
==========================================
+ Hits        60044    60773     +729     
+ Misses      13682    12956     -726     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anur7 anur7 requested review from nunesanderson and gmalinve July 18, 2025 22:04
@anur7 anur7 marked this pull request as ready for review July 18, 2025 22:10
@anur7 anur7 requested a review from a team as a code owner July 18, 2025 22:10
@anur7 anur7 requested a review from jvela018 July 21, 2025 08:29
Copy link
Contributor

@nunesanderson nunesanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmalinve I will leave it to you to approve it.
Thanks @anur7 for fixing the issue.

Copy link
Contributor

@gmalinve gmalinve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 see my comments.

@anur7 anur7 requested a review from gmalinve July 21, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in analyze_from_zero()
5 participants