Skip to content

REFACTOR: migrate choke designer extension #6364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

eblanco-ansys
Copy link
Contributor

Description

  • Migrated choke designer extension to the new standard
  • Created Choke class to create chokes in AEDT
  • Added tests to the extension

Issue linked

#6335

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@eblanco-ansys eblanco-ansys requested a review from a team as a code owner July 8, 2025 09:11
@eblanco-ansys eblanco-ansys linked an issue Jul 8, 2025 that may be closed by this pull request
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 49.80080% with 126 lines in your changes missing coverage. Please review.

Project coverage is 39.56%. Comparing base (67d9e0c) to head (0c1487e).

❌ Your patch check has failed because the patch coverage (49.80%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6364       +/-   ##
===========================================
- Coverage   85.12%   39.56%   -45.57%     
===========================================
  Files         176      177        +1     
  Lines       66963    67179      +216     
===========================================
- Hits        57003    26580    -30423     
- Misses       9960    40599    +30639     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't take the time to review yet but I see that there are missing unit tests. Could you see how other PRs have proceeded with the extension refactoring to split tests between unit and system. Could you have a look at the extension documentation ? Note that it's missing some snippet documentation, getting fixed in #6384

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate choke_designer extension
3 participants