-
Notifications
You must be signed in to change notification settings - Fork 165
REFACTOR: migrate choke designer extension #6364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (49.80%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6364 +/- ##
===========================================
- Coverage 85.12% 39.56% -45.57%
===========================================
Files 176 177 +1
Lines 66963 67179 +216
===========================================
- Hits 57003 26580 -30423
- Misses 9960 40599 +30639 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take the time to review yet but I see that there are missing unit tests. Could you see how other PRs have proceeded with the extension refactoring to split tests between unit and system. Could you have a look at the extension documentation ? Note that it's missing some snippet documentation, getting fixed in #6384
…b.com/ansys/pyaedt into 6335-migrate-choke_designer-extension
…b.com/ansys/pyaedt into 6335-migrate-choke_designer-extension
…b.com/ansys/pyaedt into 6335-migrate-choke_designer-extension
Description
Choke
class to create chokes in AEDTIssue linked
#6335
Checklist