-
Notifications
You must be signed in to change notification settings - Fork 7
feat: small layout adjustments #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm okay with centering the navbar, especially when there is no sidebar. However, if I'm not mistaken, the search might not work properly with this layout. I can test it locally to confirm. |
Please do, I haven't really checked the functionality. I have updated the PR text |
This is the search from pydata sphinx theme, not from our theme, Any way adding this change should work https://github.com/ansys/ansys-sphinx-theme/pull/691/files/ca60b135ef165289874da5da489ac1cfb086eede#r2084245571 , Thank you so much for the PR, After we merge this PR i will update #689 also, so that the laptop view will get adjusted |
Co-authored-by: Revathy Venugopal <[email protected]>
@Revathyvenugopal162 implemented changes! |
bd-content
container. This is more obvious when we hide any of the sidebars.navbar_end
so it hides when there is no space. This change probably needs some thoughts. Since the search bar "disappear" for small screens and gets located in the primary sidebar:Changes
Center navbar elements
Before
After
Centering
bd-content
container. This is more obvious when we hide any of the sidebars.Before
After
Moving search bar to
navbar_end
so it hides when there is no space. Better looking on mobile devicesBefore
After