Skip to content

feat: small layout adjustments #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2025

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented May 12, 2025

  • Center navbar elements
  • Centering bd-content container. This is more obvious when we hide any of the sidebars.
  • Moving search bar to navbar_end so it hides when there is no space. This change probably needs some thoughts. Since the search bar "disappear" for small screens and gets located in the primary sidebar:
image

Changes

Center navbar elements

Before

image

After

image

Centering bd-content container. This is more obvious when we hide any of the sidebars.

Before

image

After

image

Moving search bar to navbar_end so it hides when there is no space. Better looking on mobile devices

Before

image

After

image

@germa89 germa89 requested a review from a team as a code owner May 12, 2025 09:10
@germa89 germa89 self-assigned this May 12, 2025
@github-actions github-actions bot added the enhancement General improvements to existing features label May 12, 2025
@Revathyvenugopal162
Copy link
Contributor

I'm okay with centering the navbar, especially when there is no sidebar. However, if I'm not mistaken, the search might not work properly with this layout. I can test it locally to confirm.

@germa89
Copy link
Contributor Author

germa89 commented May 12, 2025

I'm okay with centering the navbar, especially when there is no sidebar. However, if I'm not mistaken, the search might not work properly with this layout. I can test it locally to confirm.

Please do, I haven't really checked the functionality.

I have updated the PR text

@germa89
Copy link
Contributor Author

germa89 commented May 12, 2025

It seems to work???

image image

Not sure if this is what you meant. Anyway, feel free to test and let me know because I am implementing this changes in PyMAPDL too.

@Revathyvenugopal162
Copy link
Contributor

It seems to work???

image image
Not sure if this is what you meant. Anyway, feel free to test and let me know because I am implementing this changes in PyMAPDL too.

This is the search from pydata sphinx theme, not from our theme, Any way adding this change should work https://github.com/ansys/ansys-sphinx-theme/pull/691/files/ca60b135ef165289874da5da489ac1cfb086eede#r2084245571 , Thank you so much for the PR, After we merge this PR i will update #689 also, so that the laptop view will get adjusted

@germa89
Copy link
Contributor Author

germa89 commented May 12, 2025

@Revathyvenugopal162 implemented changes!

@Revathyvenugopal162 Revathyvenugopal162 merged commit fd77281 into main May 12, 2025
19 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/centering-header-elements branch May 12, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants