Skip to content

Conversation

@pmm26
Copy link

@pmm26 pmm26 commented Sep 12, 2024

Changes:

  • Converted files to TypeScript
  • Event Start and End date are now dayjs objects instead of date strings.
  • Event Items Resolver now get the actual date and other info to allow more customization options.
  • Made it more Responsive you can now have the Schedjuler centered in the center of the screen. Space that was usally filled the Resouce Collumn. Old behavior is still the default.

Files that still have typecript issues: - I hope to get these fixed.

  • EventItem (has the most issues but I think is just because of the DnD)
  • WrapperFun.tsx (minor)
  • utility.ts (minor)

Updating items & DND is not tested and may have issues related to the change from date string to Dayjs.
If these issues can be identified I can help fix them but I don't have a lot of time.

Might be better to make a new branch to put this on if you think these changes are usefull.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10474 lines exceeds the maximum allowed for the inline comments feature.

@socket-security
Copy link

socket-security bot commented Sep 12, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment +43 8.26 MB nicolo-ribaudo
npm/@types/[email protected] None 0 34.9 kB types
npm/@types/[email protected] None +2 1.68 MB types

View full report↗︎

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10543 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10543 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10548 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10552 lines exceeds the maximum allowed for the inline comments feature.

@whoafridi
Copy link

any plan to change the class components to functional one ? @pmm26

@pmm26
Copy link
Author

pmm26 commented Sep 17, 2024

any plan to change the class components to functional one ? @pmm26

Not really while it would be nice to have them all on Functional Components. Class components still work and do the job.

Time spent vs Benefits is just not worth it at the moment for me, converting ComponentShouldUpdate ... is not that straight forward.

@ansulagrawal
Copy link
Owner

@pmm26 I will be creating a beta version of this release. Please let me know shall I do it or not?

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10559 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 10563 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b2ad54c and detected 138 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 62
Duplication 65
Clarity 1
Bug Risk 9
Style 1

Note: there are 4 critical issues.

View more on Code Climate.

pmm26 added 2 commits December 5, 2024 11:43
* next15:
  Sutff

# Conflicts:
#	package.json
@pmm26
Copy link
Author

pmm26 commented Dec 23, 2024

@ansulagrawal I'm start working on this after new year. If you start branch I can PR any changes and improvements I make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants