-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "podman: remove ansible_async_dir setting logic (#182)" #237
Open
hswong3i
wants to merge
1
commit into
ansible-community:main
Choose a base branch
from
alvistack:revert-0244719
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nity#182)" This reverts commit 0244719. Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found: |
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Feb 12, 2024
git clean -xdf tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3 rm -rf ../python*-molecule-plugins*23.5.3*.* See ansible-community#155 See ansible-community#237 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Feb 20, 2024
git clean -xdf tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3 rm -rf ../python*-molecule-plugins*23.5.3*.* See ansible-community#155 See ansible-community#237 See ansible-community#240 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Feb 28, 2024
git clean -xdf tar zcvf ../python-molecule-plugins_23.5.3.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.5.3-1.spec cp ../python*-molecule-plugins*23.5.3*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.5.3 rm -rf ../python*-molecule-plugins*23.5.3*.* See ansible-community#155 See ansible-community#237 See ansible-community#240 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Dec 20, 2024
git clean -xdf tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0 rm -rf ../python*-molecule-plugins*23.6.0*.* See ansible-community#155 See ansible-community#237 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Jan 4, 2025
git clean -xdf tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git . debuild -uc -us cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0 rm -rf ../python*-molecule-plugins*23.6.0*.* See ansible-community#155 See ansible-community#237 Signed-off-by: Wong Hoi Sing Edison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrade to https://github.com/ansible-community/molecule-plugins/releases/tag/v23.5.3, I found that all my GitLab CI pipiline running with podman driver not working (e.g. https://gitlab.com/alvistack/docker-ubuntu/-/jobs/6148073273)
After debug I found that if disable https://github.com/ansible-community/molecule-plugins/blob/v23.5.3/src/molecule_plugins/podman/playbooks/create.yml#L167-L168 as below, the create will working fine:
So this lead me to the #182, which remove the
ansible_async_dir
logic.After manually revert the commit 0244719, my problem get fixed:
This reverts commit 0244719.