Skip to content

Fix bug to handle duplicate subnet across different vpc networks #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix bug to handle duplicate subnet across different vpc networks #561

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3505b5a
fix bug to handle duplicate subnet across different vpc networks
jimmy-cui-sada Mar 2, 2023
4687397
clean up unneeded import
jimmy-cui-sada Mar 2, 2023
5a2a6f2
Update plugins/modules/gcp_compute_subnetwork.py
jimmycgz Mar 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plugins/modules/gcp_compute_subnetwork.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,7 @@
import json
import time


################################################################################
# Main
################################################################################
Expand Down Expand Up @@ -353,7 +354,10 @@ def main():

if fetch:
if state == 'present':
if is_different(module, fetch):
if module.params['network']['selfLink'] != fetch['network']: # found difference on same subnet within the same VPC network
module.fail_json(msg="Subnet already exists in a different VPC network: %s, please change the name or region" % fetch['network'])
changed = False
elif is_different(module, fetch):
update(module, self_link(module), kind, fetch)
fetch = fetch_resource(module, self_link(module), kind)
changed = True
Expand Down