Skip to content

Commit

Permalink
updates changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
toydarian committed Jan 31, 2025
1 parent 8266c9d commit ed3fd3c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
5 changes: 2 additions & 3 deletions changelogs/fragments/778-pg-hba-improvements.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
bugfixes:
- "postgresql_pg_hba - fixes #776 the module won't be adding/moving comments repeatedly if 'keep_comments_at_rules' is 'false' (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - fixes #777 the module will ignore the 'address' and 'netmask' options again when the contype is 'local' (https://github.com/ansible-collections/community.postgresql/pull/778)"
minor_changes:
- "postgresql_pg_hba - regarding #776 'keep_comments_at_rules' has been deprecated and won't do anything (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - regarding #776 'keep_comments_at_rules' has been deprecated and won't do anything, the default is to keep the comments at the rules they are specified with (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - adds a parameter 'sort_rules' that allows the user to disable sorting in the module, the default is the previous behavior (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - will read all kinds of includes and add them to the end of the file in the same order as they were in the original file, does not allow to add includes (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - regarding #795 will read all kinds of includes and add them to the end of the file in the same order as they were in the original file, does not allow to add includes (https://github.com/ansible-collections/community.postgresql/pull/778)"
- "postgresql_pg_hba - adds 'pg_hba_string' which contains the string that is written to the file to the output of the module (https://github.com/ansible-collections/community.postgresql/pull/778)"
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@
that:
- '"host\tall\tall\t2001:db8::1/128\tmd5\t#comment1\nhost\tall\tall\t2001:db8::2/128\tmd5\t#comment2\nhost\tall\tall\t2001:db8::3/128\tmd5\t#comment3" == content'

- community.postgresql.postgresql_pg_hba:
- name: test local with default address
community.postgresql.postgresql_pg_hba:
dest: /tmp/pg_hba3.conf
contype: local
method: trust
Expand All @@ -264,7 +265,8 @@
- assert:
that: 'local_with_address.pg_hba == [{"db": "all", "method": "trust", "type": "local", "usr": "all"}]'

- community.postgresql.postgresql_pg_hba:
- name: test that local ignores address when supplied
community.postgresql.postgresql_pg_hba:
dest: /tmp/pg_hba3.conf
contype: local
method: trust
Expand All @@ -276,8 +278,9 @@
- assert:
that: 'local_with_address.pg_hba == [{"db": "all", "method": "trust", "type": "local", "usr": "all"}]'

- community.postgresql.postgresql_pg_hba:
dest: pg_hba.conf
- name: test that it fails on invalid usernames
community.postgresql.postgresql_pg_hba:
dest: /tmp/pg_hba.conf
users: '{ "oh": "no" }'
state: present
contype: host
Expand All @@ -289,7 +292,7 @@
that: invalid_username is failed

- community.postgresql.postgresql_pg_hba:
dest: pg_hba.conf
dest: /tmp/pg_hba.conf
users: oops
state: present
contype: host
Expand Down

0 comments on commit ed3fd3c

Please sign in to comment.