Fix import error on Python 3.13 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework `escape_param` to work on Python 3.13. One of `shlex.quote` or `pipes.quote` exists on all Python versions (back to Python 0.9.8!), so the fallback code for systems that have neither is unnecessary.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #684 +/- ##
==========================================
- Coverage 73.68% 73.44% -0.25%
==========================================
Files 6 6
Lines 935 934 -1
Branches 144 143 -1
==========================================
- Hits 689 686 -3
Misses 210 210
- Partials 36 38 +2 ☔ View full report in Codecov by Sentry. |
|
I never used Python as far back as Python 0.9.8. But I did have a docker image that had neither of these libraries. Perhaps that was pretty unusual. Seems to not be an issue in the CI anymore. |
|
I think that image must have been mangled in some way to remove parts of the standard library. I'm surprised anything worked there ... |
|
Yes probably. But it's gone now. Merging! |
rhysmeister
merged commit 30def22
into
ansible-collections:master
202 of 204 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rework
escape_paramto work on Python 3.13. One ofshlex.quoteorpipes.quoteexists on all Python versions (back to Python 0.9.8!), so the fallback code for systems that have neither is unnecessary.ISSUE TYPE
COMPONENT NAME
module_utils