Skip to content

Remove unnecessary changelog fragment from main #2315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beeankha
Copy link
Contributor

This changelog fragment has already been accounted for via the recent 10.0.0 release; see "Deprecated Features" section of the release changelog.

@beeankha beeankha added the do_not_backport This PR should not be backported to stable- branches unless absolutely necessary label May 20, 2025
@beeankha beeankha changed the title Remove unnecessary changelog fragment from main Remove unnecessary changelog fragment from main May 20, 2025
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/19b8c8982f024b4d871073c1079b90c8

ansible-galaxy-importer FAILURE in 3m 58s (non-voting)
✔️ build-ansible-collection SUCCESS in 10m 49s

@tremble
Copy link
Contributor

tremble commented May 21, 2025

Rather than removing the fragment, do we want to keep a fragment that we'll be dropping support for "less than Python 3.9" in release 12.0.0 ("after 2026-05-01")?

@alinabuzachis
Copy link
Contributor

I don't understand what's going on. I see that this changelog fragment has not been used when 10.0 has been prepped. I don't see a breaking change https://github.com/ansible-collections/community.aws/blob/main/CHANGELOG.rst#breaking-changes--porting-guide. Am I missing something?

@beeankha
Copy link
Contributor Author

I don't understand what's going on. I see that this changelog fragment has not been used when 10.0 has been prepped. I don't see a breaking change https://github.com/ansible-collections/community.aws/blob/main/CHANGELOG.rst#breaking-changes--porting-guide. Am I missing something?

It's odd because stable-10 has the correct matrix_exclude entries in both sanity.yml and units.yml, as submitted in #2304 , but (as you point out) the changelog fragment didn't get properly deleted. I initially thought maybe the stable-10 branch was cut from a version of main that wasn't fully up-to-date, but then the workflows should also be outdated, so I'm not quite sure what happened.

I can do the following things in order to clear things up:

  • In addition to deleting the changelog fragment via this PR (what I've already done) I can manually move the changelog fragment content into the Breaking Changes section and out of the Deprecated Features section.
  • I can replace what was moved out of the Deprecated Features section with what @tremble suggested in his comment above OR I can create a changelog fragment with the info about deprecation, if that is preferred.

If the above steps are implemented:

  • I can update changelog.rst and changelog.yaml files in a separate PR for stable-10 so that those are both up-to-date.
  • Manually update the 10.0.0 release changelog to reflect any changes that were implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do_not_backport This PR should not be backported to stable- branches unless absolutely necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants