Skip to content

AAP-46677-updated-workspace-logic #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

shvenkat-rh
Copy link

@shvenkat-rh shvenkat-rh commented Jun 26, 2025

SUMMARY

Please refer to https://issues.redhat.com/browse/AAP-46677.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

terraform.py

ADDITIONAL INFORMATION

f the workspace is given in the playbook - Then use that version
if there is a mismatch between the playbook and the one in the cloud config then an error would likely occur
If the workspace is not given and cloud block is present - Then use workspace from cloud block version

Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 98.17073% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.95%. Comparing base (8c52bf2) to head (92d00c2).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
tests/unit/plugins/modules/test_terraform.py 98.13% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #197       +/-   ##
===========================================
+ Coverage   73.00%   85.95%   +12.95%     
===========================================
  Files          16       23        +7     
  Lines        1015     1766      +751     
  Branches      182      347      +165     
===========================================
+ Hits          741     1518      +777     
+ Misses        243      190       -53     
- Partials       31       58       +27     
Flag Coverage Δ
sanity ?
units 85.95% <98.17%> (+13.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/3cb0327efb3c4f389ca67e2e59e42513

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 50s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e968034a185a476fa36b21829ab55f6f

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 6m 14s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e5886ebcc9294de2b211e008e812f7b4

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 43s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5384998299af47b4a225e73658313413

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 46s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c477408d71564f3cafba1da91eb0a3dd

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 47s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7643c90a586c4fbda098402620e8812d

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 6m 09s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7d0fada89aab4630979e0d8743d0641d

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 49s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1772449056d24b7e9c3d8f0404fc332b

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 48s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6c011554e78e482682350882ae726b4c

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 48s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f591b9547fd04780bcaeebc692359b73

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 47s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/50d090bc5efa4c069e5d1e2a881681f7

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 46s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d4688c1572a5484dae49f7c6f411d444

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 6m 04s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7d38f7f3a2214eaea59400d99ca16044

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 47s

@shvenkat-rh shvenkat-rh marked this pull request as ready for review June 30, 2025 13:02
@shvenkat-rh shvenkat-rh changed the title AAP-46677-first-commit AAP-46677-updated-workspace-logic Jun 30, 2025
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e7202fca3f18454fa4b55a85314f7fc8

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 48s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a80194a1accd4e8990133b6978e0bc4d

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 46s

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2c03efaced244f7c8cd6ee181590796e

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 5m 46s

@gravesm
Copy link
Member

gravesm commented Jun 30, 2025

recheck

Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/82f0bd0274ae405f85688f312ae7af42

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection POST_FAILURE in 13m 13s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants