AAP-46677-updated-terraform.py

[shvenkat-rh]

SUMMARY

Please refer to https://issues.redhat.com/browse/AAP-46677.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

terraform.py

ADDITIONAL INFORMATION

f the workspace is given in the playbook - Then use that version
if there is a mismatch between the playbook and the one in the cloud config then an error would likely occur
If the workspace is not given and cloud block is present - Then use workspace from cloud block version
If the workspace is not given and cloud block is not used - Then use CLI version (existing logic).

Also I have added a TF file parser which removes comments from the TF file.

[codecov]

Codecov Report

Attention: Patch coverage is 73.28767% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.77%. Comparing base (8c52bf2) to head (578b3a5).
Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
plugins/modules/terraform.py	59.79%	36 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   73.00%   80.77%   +7.76%     
==========================================
  Files          16       23       +7     
  Lines        1015     1737     +722     
  Branches      182      343     +161     
==========================================
+ Hits          741     1403     +662     
- Misses        243      289      +46     
- Partials       31       45      +14     

Flag	Coverage Δ
sanity	?
units	80.77% <73.28%> (+8.16%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/35c94473a450402d993f3d598a17ea01

✔️ ansible-galaxy-importer SUCCESS in 3m 21s
✔️ build-ansible-collection SUCCESS in 7m 28s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4afeea8f3b8d48549bf7af074caeddb6

✔️ ansible-galaxy-importer SUCCESS in 3m 16s
✔️ build-ansible-collection SUCCESS in 5m 50s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7071b37d71b54a96b74b719c7d3208a3

✔️ ansible-galaxy-importer SUCCESS in 3m 12s
✔️ build-ansible-collection SUCCESS in 5m 43s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ef025a5ddd544930ac438974300633db

✔️ ansible-galaxy-importer SUCCESS in 3m 14s
✔️ build-ansible-collection SUCCESS in 6m 06s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dfb4e51911d84c5c8adc747076da6e17

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 51s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e0f4b70936c244248ff67fdf87ac6e15

✔️ ansible-galaxy-importer SUCCESS in 3m 20s
✔️ build-ansible-collection SUCCESS in 5m 52s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/703625dd3cb84515b0d78e0996b4defb

✔️ ansible-galaxy-importer SUCCESS in 3m 14s
✔️ build-ansible-collection SUCCESS in 5m 49s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3efa3a999731473a86c8e8af2e9c3147

✔️ ansible-galaxy-importer SUCCESS in 3m 32s
✔️ build-ansible-collection SUCCESS in 5m 51s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/78f1317ee6b54ba985c543953ab7b6bc

✔️ ansible-galaxy-importer SUCCESS in 3m 08s
✔️ build-ansible-collection SUCCESS in 5m 46s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/331cb297b52a4f8aaf06595dadd2aba7

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 56s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/50fd9f437d464ee5b79b8f48fdf8ed5e

✔️ ansible-galaxy-importer SUCCESS in 2m 50s
✔️ build-ansible-collection SUCCESS in 5m 49s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b12f627af7b84acea5b5d1f1fa97c1ac

✔️ ansible-galaxy-importer SUCCESS in 3m 41s
✔️ build-ansible-collection SUCCESS in 5m 45s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1b374e76e7494fa7992e9b2a65863fd6

✔️ ansible-galaxy-importer SUCCESS in 3m 17s
✔️ build-ansible-collection SUCCESS in 5m 47s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6a51ea5f90fd402397cccf18fd8f17fa

✔️ ansible-galaxy-importer SUCCESS in 3m 15s
✔️ build-ansible-collection SUCCESS in 5m 41s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2050668d8f0543da836d01fbf5bba4da

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 5m 49s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/02a5ed411cf7490f8a673328254284b9

✔️ ansible-galaxy-importer SUCCESS in 3m 56s
✔️ build-ansible-collection SUCCESS in 6m 10s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3280987d001b4144a0ba8b8df48a713c

✔️ ansible-galaxy-importer SUCCESS in 3m 40s
✔️ build-ansible-collection SUCCESS in 5m 52s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c28f6551758f46fcbd8849ebed06bd37

✔️ ansible-galaxy-importer SUCCESS in 3m 17s
✔️ build-ansible-collection SUCCESS in 5m 47s

[gravesm]

I have a lot of concerns about this PR. The parsing logic currently does not account for:

• nested blocks
• jsonencode
• heredoc syntax
• workspace tags
• terraform config written in json

In addition, we're opening and reading every file in the directory and then looping over every single character in every one of those files, and that's being done every time this module is used.

Can we not just use workspace list to figure out what workspace terraform thinks is configured? I'm not clear on what problem this PR is trying to solve.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c05491256b6941e689093a4f1c1f9831

✔️ ansible-galaxy-importer SUCCESS in 3m 22s
✔️ build-ansible-collection SUCCESS in 5m 48s