Skip to content

fix(acl): correctly assert needed changes when recursive is true#638

Open
Silejonu wants to merge 2 commits intoansible-collections:mainfrom
Silejonu:main
Open

fix(acl): correctly assert needed changes when recursive is true#638
Silejonu wants to merge 2 commits intoansible-collections:mainfrom
Silejonu:main

Conversation

@Silejonu
Copy link
Copy Markdown

@Silejonu Silejonu commented May 7, 2025

SUMMARY

Right now, when setting recursive ACLs on a directory, all files in the directory are tested to check if a change is needed. If a single file has expected ACLs already set, then the test returns False and no changes are applied.

Fixes #592

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

acl

ADDITIONAL INFORMATION

I'm very much a beginner in Python, so any criticism is welcome.

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

@softwarefactory-project-zuul
Copy link
Copy Markdown
Contributor

@dnorthup-ums
Copy link
Copy Markdown

dnorthup-ums commented Feb 3, 2026

@Silejonu Is there a chance you could add additional test cases to the relevant tests ( in tests/integration/targets/acl/tasks/acl.yml ) to help prevent accidental introduction of regression bugs in the future? I think that may make it more likely that the team will accept your pull request. (I'm not part of the team maintaining this, but that's what I've been told by related teams in the past.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default ACL are not set recursively if file is present in subfolder

2 participants