fix(acl): correctly assert needed changes when recursive is true#638
fix(acl): correctly assert needed changes when recursive is true#638Silejonu wants to merge 2 commits intoansible-collections:mainfrom
Conversation
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 13s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 16s |
|
@Silejonu Is there a chance you could add additional test cases to the relevant tests ( in tests/integration/targets/acl/tasks/acl.yml ) to help prevent accidental introduction of regression bugs in the future? I think that may make it more likely that the team will accept your pull request. (I'm not part of the team maintaining this, but that's what I've been told by related teams in the past.) |
SUMMARY
Right now, when setting recursive ACLs on a directory, all files in the directory are tested to check if a change is needed. If a single file has expected ACLs already set, then the test returns
Falseand no changes are applied.Fixes #592
ISSUE TYPE
COMPONENT NAME
acl
ADDITIONAL INFORMATION
I'm very much a beginner in Python, so any criticism is welcome.