Fix sanitize mount src before comparing to mount point for macOS #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The mount command
mount_smbfs
on macOS doesn't have a separated parameter for password, hence thesrc
parameter attaches password like below:It occurs below error when it mounted on second run:
Ephemeral mount point is already mounted with a different source than the specified one. Failing in order to prevent an unwanted unmount or override operation. Try replacing this command with a \"state: unmounted\" followed by a \"state: ephemeral\", or use a different destination path.
The reason is it trying to compare
src: //{{SYNOLOGY_USERNAME}}:{{SYNOLOGY_PASSWORD}}@10.10.10.251/storage
to the mount point:
//{{SYNOLOGY_USERNAME}}@10.10.10.251/storage
ISSUE TYPE
COMPONENT NAME
mount
ADDITIONAL INFORMATION