Repository navigation
Add CLAUDE.md with repository conventions - #40
Merged
Merged
Conversation
Records the things that were repeatedly re-derived while working on the .NET 10 migration, so they do not have to be rediscovered each session: - which project is live and which is deprecated, since the solution still contains both and the deprecated one no longer builds - the build, test and publish commands, including that publishing needs -r win-x64 on the command line while the rest of the options are in the csproj - why tests stop short of the real Konaste service, and the STA/MessageBox constraints that follow from testing a WinForms tray app - three specific traps: appinfo.json path resolution, the WebView2 reference that looks unused but is needed for #29, and the regenerated Settings.Designer.cs Also sets the commit and PR conventions: branch-and-PR rather than direct pushes to main, and no attribution lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CLAUDE.mdso the conventions and constraints that kept getting re-derived during the .NET 10 migration are written down once.Contents:
src/KsGameLauncher2and the deprecatedKsGameLauncher, and the deprecated one no longer builds under the current SDK. Worth stating explicitly since the layout alone doesn't make it obvious.-r win-x64on the command line while the rest of the single-file options live in the csproj, and that there is nonuget restorestep any more.[StaFact]rather than[Fact], and never calling theMessageBox-bearing launch paths from a test.appinfo.jsonpath resolution (Save appinfo.json next to the executable instead of the working directory #39), theMicrosoft.Web.WebView2reference that looks unused but is needed for Login issue #29, and the regeneratedSettings.Designer.csthat must not be hand-edited.main, and no attribution lines on commits or PR descriptions.Reviewer notes
This file only affects Claude Code sessions; it changes nothing about the build. Note that this PR and its commit already follow the new no-attribution rule.