Repository navigation
Add GitHub Actions CI and release automation - #37
Merged
Merged
Conversation
The repository had no CI at all, so the 25 tests added alongside the .NET 10 migration were never run automatically, and releases were built by hand in Visual Studio. CI workflow: builds the solution and runs the tests on windows-latest for pushes to main and for every pull request. Windows is required because the app targets net10.0-windows and uses WinForms. Release workflow: triggered by a v* tag (or manually with a tag input). Tests, publishes the single-file build, zips it flat as ksgamelauncher-<tag>.zip and attaches it to a generated GitHub release. The flat layout and the ksgamelauncher-<tag>.zip name match what the existing update.xml feed already points AutoUpdater.NET at, so the updater keeps working unchanged. update.xml itself is hosted outside this repository, so pointing it at a new version stays a manual step; noted in the README. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository had no CI at all (no
.github/, the only yml wasdocker-compose.ymlfor the local mock web server). So the 25 tests added alongside the .NET 10 migration were never run automatically, and releases were built by hand in Visual Studio — previously via the deprecated project's ILMergePostBuildEvent.ci.ymlBuilds the solution and runs the tests on
windows-latest, for pushes tomainand every pull request (plus manual dispatch). Windows is required — the app targetsnet10.0-windowsand uses WinForms. The deprecated .NET Framework project is excluded from the solution's default build configuration, so this buildsKsGameLauncher2and its test project only.release.ymlTriggered by a
v*tag (or manually with a tag input). Tests → publishes the single-file build → zips it flat asksgamelauncher-<tag>.zip→ attaches it to a generated GitHub release.The flat layout and the
ksgamelauncher-<tag>.zipname deliberately match what the existing feed already points AutoUpdater.NET at:so the updater keeps working unchanged — the archive just contains 3 files now instead of 45.
Reviewer notes
update.xmlstays manual. It's hosted outside this repository (launcher-app.sdvx.net), so pointing it at a new version is still a hand step. Called out in the README.contents: writepermission is scoped to the release job only, needed forgh release create.Test plan
dotnet build KsGameLauncher.slnanddotnet testpass locally (25/25) — the exact commands the CI job runswindows-latest:Total tests: 25 / Passed: 25. This also confirms the WinForms tests (which create a realNotifyIconwithVisible = true) run fine on a GitHub-hosted runner — the main risk with this workflow.🤖 Generated with Claude Code